[issue39903] Double decref in _elementtree.Element.__getstate__

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39903] Double decref in _elementtree.Element.__getstate__

[miss-islington]

miss-islington  added the comment:


New changeset 97bbdb28b4ab9519780f924e3267ac70af1cd5b8 by Miss Islington (bot) 
in branch '3.8':
bpo-39903: Fix double decref in _elementtree.Element.__getstate__ (GH-18850)
https://github.com/python/cpython/commit/97bbdb28b4ab9519780f924e3267ac70af1cd5b8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39903] Double decref in _elementtree.Element.__getstate__

[miss-islington]

miss-islington  added the comment:


New changeset 80be9c344f9fa619c24712c699b70126fc202315 by Miss Islington (bot) 
in branch '3.7':
bpo-39903: Fix double decref in _elementtree.Element.__getstate__ (GH-18850)
https://github.com/python/cpython/commit/80be9c344f9fa619c24712c699b70126fc202315


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39903] Double decref in _elementtree.Element.__getstate__

[miss-islington]

Change by miss-islington :


--
pull_requests: +18233
pull_request: https://github.com/python/cpython/pull/18875

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39903] Double decref in _elementtree.Element.__getstate__

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 88944a44aa84b0f3674939019b1befbc7a9dc874 by Serhiy Storchaka in 
branch 'master':
bpo-39903: Fix double decref in _elementtree.Element.__getstate__ (GH-18850)
https://github.com/python/cpython/commit/88944a44aa84b0f3674939019b1befbc7a9dc874


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39903] Double decref in _elementtree.Element.__getstate__

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +18232
pull_request: https://github.com/python/cpython/pull/18874

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39903] Double decref in _elementtree.Element.__getstate__

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +18207
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18850

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39903] Double decref in _elementtree.Element.__getstate__

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

There is very strange code in _elementtree.Element.__getstate__ which decrement 
references to elements of a list before decrementing a reference to the list 
itself. It happens only if creating a dict fails, so it is almost impossible to 
reproduce, but if it happens it will likely cause a crash.

The proposed PR fixes the bug and also simplifies the code.

--
components: Extension Modules, XML
messages: 363657
nosy: eli.bendersky, scoder, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Double decref in _elementtree.Element.__getstate__
type: crash
versions: Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com