[issue40024] Add PyModule_AddType helper function

[Kyle Stanley]

Kyle Stanley  added the comment:

(disregard the above, the PR was mistakenly linked from a GitHub bug)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40024] Add PyModule_AddType helper function

[Kyle Stanley]

Change by Kyle Stanley :


--
pull_requests:  -18641

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40024] Add PyModule_AddType helper function

[Kyle Stanley]

Change by Kyle Stanley :


--
nosy: +aeros
nosy_count: 3.0 -> 4.0
pull_requests: +18641
pull_request: https://github.com/python/cpython/pull/19282

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40024] Add PyModule_AddType helper function

[STINNER Victor]

STINNER Victor  added the comment:

Thanks Dong-hee Na for fixing many reference leaks! I like the new 
PyModule_AddType() helper function.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40024] Add PyModule_AddType helper function

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 016bdd519d76c282bbe0220c67a49226b6262638 by Dong-hee Na in branch 
'master':
bpo-40024: Update _elementtree to use PyModule_AddType() (GH-19205)
https://github.com/python/cpython/commit/016bdd519d76c282bbe0220c67a49226b6262638


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40024] Add PyModule_AddType helper function

[hai shi]

Change by hai shi :


--
nosy: +shihai1991

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40024] Add PyModule_AddType helper function

[Dong-hee Na]

Dong-hee Na  added the comment:

@vstinner

IMHO, we can close this issue after PR 19205 is merged.
Most of use cases are replaced to PyModule_AddType.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40024] Add PyModule_AddType helper function

[Dong-hee Na]

Change by Dong-hee Na :


--
title: Add _PyModule_AddType private helper function -> Add PyModule_AddType 
helper function

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com