[issue40071] test__xxsubinterpreters leaked [1, 1, 1] references: test_ids_global()

STINNER Victor added the comment: I closed the issue, the leak is now fixed and _functools has been fixed. I created bpo-40137: TODO list when PEP 573 "Module State Access from C Extension Methods" will be implemented. -- resolution: -> fixed stage: patch review -> resolved status:

[issue40071] test__xxsubinterpreters leaked [1, 1, 1] references: test_ids_global()

STINNER Victor added the comment: New changeset eacc07439591c97f69ab4a3d17391b009cd78ae2 by Paulo Henrique Silva in branch 'master': bpo-40071: Fix potential crash in _functoolsmodule.c (GH-19273) https://github.com/python/cpython/commit/eacc07439591c97f69ab4a3d17391b009cd78ae2 --

[issue40071] test__xxsubinterpreters leaked [1, 1, 1] references: test_ids_global()

Paulo Henrique Silva added the comment: As discussed on PR19172, this module uses a global state in functions that do not receive a PyModule* and right now converting such cases to per-module state is not trivial. I will wait for PEP-573 implementation that will hopefully make this easier.

[issue40071] test__xxsubinterpreters leaked [1, 1, 1] references: test_ids_global()

Change by Paulo Henrique Silva : -- pull_requests: +18628 pull_request: https://github.com/python/cpython/pull/19273 ___ Python tracker ___

[issue40071] test__xxsubinterpreters leaked [1, 1, 1] references: test_ids_global()

STINNER Victor added the comment: > (...) will convert it to use per-module state in a separate issue. Great! -- ___ Python tracker ___

[issue40071] test__xxsubinterpreters leaked [1, 1, 1] references: test_ids_global()

STINNER Victor added the comment: New changeset b09ae3ff43111a336c0b706ea32fa07f88c992d9 by Paulo Henrique Silva in branch 'master': bpo-40071: Fix refleak in _functools module (GH19172) https://github.com/python/cpython/commit/b09ae3ff43111a336c0b706ea32fa07f88c992d9 --

[issue40071] test__xxsubinterpreters leaked [1, 1, 1] references: test_ids_global()

Paulo Henrique Silva added the comment: The module still uses static state. Fixed the leak and will convert it to use per-module state in a separate issue. -- ___ Python tracker

[issue40071] test__xxsubinterpreters leaked [1, 1, 1] references: test_ids_global()

Change by Paulo Henrique Silva : -- pull_requests: +18532 pull_request: https://github.com/python/cpython/pull/19172 ___ Python tracker ___

[issue40071] test__xxsubinterpreters leaked [1, 1, 1] references: test_ids_global()

Paulo Henrique Silva added the comment: I've got it, will investigate asap. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue40071] test__xxsubinterpreters leaked [1, 1, 1] references: test_ids_global()

STINNER Victor added the comment: The folowing test is enough to reproduce the leak: def test_ids_global(self): interp1 = interpreters.create() script, rpipe = _captured_script("pass") interpreters.run_string(interp1, script) rpipe.close() interp2

[issue40071] test__xxsubinterpreters leaked [1, 1, 1] references: test_ids_global()

Change by Paulo Henrique Silva : -- keywords: +patch nosy: +phsilva nosy_count: 1.0 -> 2.0 pull_requests: +18529 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19151 ___ Python tracker

[issue40071] test__xxsubinterpreters leaked [1, 1, 1] references: test_ids_global()

New submission from STINNER Victor : $ ./python -m test -R 3:3 test__xxsubinterpreters -m test_ids_global 0:00:00 load avg: 0.80 Run tests sequentially 0:00:00 load avg: 0.80 [1/1] test__xxsubinterpreters beginning 6 repetitions 123456 .. test__xxsubinterpreters leaked [1, 1, 1] references,