[issue40086] test_etree is skipped in test_typing due to cElementTree removal

[Furkan Onder]

Furkan Onder  added the comment:

@xtreak You're welcome :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40086] test_etree is skipped in test_typing due to cElementTree removal

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Thanks @furkanonder for the patch.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40086] test_etree is skipped in test_typing due to cElementTree removal

[Ivan Levkivskyi]

Ivan Levkivskyi  added the comment:


New changeset 34b0598295284e3ff6cedf5c05e159ce1fa54d60 by Furkan Önder in 
branch 'master':
bpo-40086: Update/fix test_etree test case in test_typing (GH-19189)
https://github.com/python/cpython/commit/34b0598295284e3ff6cedf5c05e159ce1fa54d60


--
nosy: +levkivskyi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40086] test_etree is skipped in test_typing due to cElementTree removal

[Furkan Önder]

Change by Furkan Önder :


--
keywords: +patch
nosy: +furkanonder
nosy_count: 2.0 -> 3.0
pull_requests: +18549
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/19189

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40086] test_etree is skipped in test_typing due to cElementTree removal

[Karthikeyan Singaravelan]

New submission from Karthikeyan Singaravelan :

Currently, test_etree has a Python 2 shim importing cElementTree and skipping 
the test on ImportError. Since cElementTree was deprecated and removed in 
Python 3 with 36543. So this test is now skipped. The fix would be to remove 
the shim and import Element from xml.etree.ElementTree. This is a good beginner 
issue. Test log as below : 

./python -m test test_typing -m test_etree -vvv
== CPython 3.9.0a5+ (heads/master:33f15a16d4, Mar 27 2020, 11:15:48) [GCC 7.5.0]
== Linux-4.15.0-66-generic-x86_64-with-glibc2.27 little-endian
== cwd: /root/cpython/build/test_python_24162
== CPU count: 1
== encodings: locale=UTF-8, FS=utf-8
0:00:00 load avg: 0.07 Run tests sequentially
0:00:00 load avg: 0.07 [1/1] test_typing
test_etree (test.test_typing.UnionTests) ... skipped 'cElementTree not found'

--

Ran 1 test in 0.001s

OK (skipped=1)

== Tests result: SUCCESS ==

1 test OK.

Total duration: 150 ms
Tests result: SUCCESS

--
components: Tests, XML
messages: 365143
nosy: serhiy.storchaka, xtreak
priority: normal
severity: normal
stage: needs patch
status: open
title: test_etree is skipped in test_typing due to cElementTree removal
type: behavior
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com