[issue40300] logging.Formatter crashes when default_msec_format is None.

[Vinay Sajip]

Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40300] logging.Formatter crashes when default_msec_format is None.

[Vinay Sajip]

Vinay Sajip  added the comment:


New changeset 06a35542aad15666cace307d841a95e33f3cbee6 by Mariusz Felisiak in 
branch 'master':
bpo-40300: Allow empty logging.Formatter.default_msec_format. (GH-19551)
https://github.com/python/cpython/commit/06a35542aad15666cace307d841a95e33f3cbee6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40300] logging.Formatter crashes when default_msec_format is None.

[Mariusz Felisiak]

Change by Mariusz Felisiak :


--
keywords: +patch
pull_requests: +18897
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/19551

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40300] logging.Formatter crashes when default_msec_format is None.

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40300] logging.Formatter crashes when default_msec_format is None.

[Mariusz Felisiak]

New submission from Mariusz Felisiak :

We would like to subclass logging.Formatter with a custom "default_time_format" 
and an empty "default_msec_format". Unfortunately logging.Formatter crashes 
when default_msec_format is None, see [1].

I'm happy to provide a patch.

[1] 
https://github.com/python/cpython/blob/5907e61a8d4da6d0f11bf1062d6d17484560a15e/Lib/logging/__init__.py#L607

--
components: Library (Lib)
messages: 366589
nosy: Mariusz Felisiak
priority: normal
severity: normal
status: open
title: logging.Formatter crashes when default_msec_format is None.
type: enhancement
versions: Python 3.6, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com