[issue40462] [easy] undefined name in Lib/test/mock_socket.py

Furkan Onder added the comment: You are welcome :=) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

STINNER Victor added the comment: Thanks for the fix Furkan Önder! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

STINNER Victor added the comment: New changeset 4b972faf605912092013a1fdbf486c498d002926 by Victor Stinner in branch 'master': bpo-40462: Fix typo in test_json (GH-20094) https://github.com/python/cpython/commit/4b972faf605912092013a1fdbf486c498d002926 --

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

Change by STINNER Victor : -- pull_requests: +19400 pull_request: https://github.com/python/cpython/pull/20094 ___ Python tracker ___

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

Change by STINNER Victor : -- pull_requests: -19288 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

Change by Furkan Onder : -- pull_requests: +19288 pull_request: https://github.com/python/cpython/pull/19972 ___ Python tracker ___

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

STINNER Victor added the comment: > IMHO we should create backport patch for 3.8 and 3.7 It's deadcode, I don't think that it's worth it. But it's up to you. If you consider that it's worth it, go ahead and backport the fix. -- ___ Python tracker

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

Dong-hee Na added the comment: @vstinner IMHO we should create backport patch for 3.8 and 3.7 3.8 and 3.7 has same codes for this. https://github.com/python/cpython/blob/3.8/Lib/test/mock_socket.py#L95 -- nosy: +corona10 ___ Python tracker

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

miss-islington added the comment: New changeset 719e14d2837520c18398a3e22a36f20c1fe76edf by Furkan Önder in branch 'master': bpo-40462: fix variable and function names (GH-19832) https://github.com/python/cpython/commit/719e14d2837520c18398a3e22a36f20c1fe76edf -- nosy:

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

Furkan Onder added the comment: Hello, I sent a PR that corrects variable and function names. I'm not sure how to fix it for Lib/test/test_json/test_recursion.py:55:24 so I didn't make any changes. -- ___ Python tracker

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

Change by Furkan Onder : -- keywords: +patch nosy: +furkanonder nosy_count: 1.0 -> 2.0 pull_requests: +19151 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19832 ___ Python tracker

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

STINNER Victor added the comment: Another one: Lib/unittest/test/test_program.py:191:40 undefined name 'hasInstallHandler' Code: def testBufferCatchFailfast(self): program = self.program for arg, attr in (('buffer', 'buffer'), ('failfast', 'failfast'),

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

STINNER Victor added the comment: Another one: Lib/test/test_json/test_recursion.py:55:24 undefined name 'pyjson' Code: def test_defaultrecursion(self): class RecursiveJSONEncoder(self.json.JSONEncoder): recurse = False def default(self, o):

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

STINNER Victor added the comment: Another one: Lib/test/test_frame.py:53:17 undefined name 'inner' I guess that self.inner() should be used instead of inner(). In practice, it's dead code, but fixing it would make pyflakes happier :-) -- ___

[issue40462] [easy] undefined name in Lib/test/mock_socket.py

New submission from STINNER Victor : pyflakes found the following issues in sendall(): Lib/test/mock_socket.py:95:21 undefined name 'data' Lib/test/mock_socket.py:96:28 undefined name 'data' Lib/test/mock_socket.py:97:20 undefined name 'data' Code: def sendall(self, buffer, flags=None):