[issue40536] Addition of a "list of available time zones" function to zoneinfo

Paul Ganssle added the comment: Thanks Łukasz. Sorry I forgot to respond last time. We've had no feedback on this whatsoever, and I think we've probably made the right choice, so we can go ahead and call this resolved. -- resolution: -> fixed stage: patch review -> resolved status:

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Łukasz Langa added the comment: Note: the release of the last RC is imminent. Whatever API changes were planned, they have to wait for 3.10. -- priority: deferred blocker -> critical versions: +Python 3.10 -Python 3.9 ___ Python tracker

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Łukasz Langa added the comment: Note: next week is 3.9.0b5, the last beta before 3.9.0. Please decide what to do with the rest of the issue before then. -- ___ Python tracker

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Change by Łukasz Langa : -- priority: release blocker -> deferred blocker ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Łukasz Langa added the comment: This goes into 3.9, but please settle on a final design long before October. Scratch that, please do it ideally before beta 2. I'm downgrading from release blocker, exception handling can be discussed and changed after beta 1 as well. --

[issue40536] Addition of a "list of available time zones" function to zoneinfo

STINNER Victor added the comment: def valid_key(fpath): try: with open(fpath, "rb") as f: return f.read(4) == b"TZif" except Exception: # pragma: nocover return False Why not only catching "except OSError:" rather than any exception?

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Paul Ganssle added the comment: I've merged the existing implementation, but I'm leaving this staged as "release blocker" so that Łukasz can have final say on whether this goes into 3.9. Thanks for the help everyone! -- ___ Python tracker

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Paul Ganssle added the comment: New changeset e527ec8abe0849e784ce100f53c2736986b670ae by Paul Ganssle in branch 'master': bpo-40536: Add zoneinfo.available_timezones (GH-20158) https://github.com/python/cpython/commit/e527ec8abe0849e784ce100f53c2736986b670ae --

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Change by Filipe Laíns : -- nosy: +FFY00 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40536] Addition of a "list of available time zones" function to zoneinfo

gaborbernat added the comment: I think semantically the correct expression would be available timezones, free function, set and no cache. Document the operation is expensive and users should cache if they want repeated access or provide an available timezones cached function  my 2c

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Paul Ganssle added the comment: I've opened a PR adding this feature and tagged this as release blocker, since I'd like to make sure this is in the beta if Łukasz does not object. The concerns about the stability of the function I expressed earlier have not changed much, though we did get

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Change by Paul Ganssle : -- pull_requests: +19461 pull_request: https://github.com/python/cpython/pull/20158 ___ Python tracker ___

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Paul Ganssle added the comment: >From some discussion on the reference implementation PR, it seems that this >may be a more complicated feature than I had bargained for: >https://github.com/pganssle/zoneinfo/pull/60 The issue is that the current implementation picks up the posix/ and right/

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Change by Paul Ganssle : -- pull_requests: -19344 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Change by Paul Ganssle : -- keywords: +patch pull_requests: +19344 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19909 ___ Python tracker ___

[issue40536] Addition of a "list of available time zones" function to zoneinfo

Paul Ganssle added the comment: I have an initial implementation against the reference implementation here: https://github.com/pganssle/zoneinfo/pull/60 Once GH-19909 is merged, I will turn that into a PR against CPython. For the first pass I went with: 1. free-standing function 2.

[issue40536] Addition of a "list of available time zones" function to zoneinfo

New submission from Paul Ganssle : One thing that I sort of overlooked in PEP 615 that I think will be a common feature request for zoneinfo is the ability to get a list of time zones available on the current TZPATH. This is more complicated to implement than it sounds like, but luckily I