[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

Irit Katriel added the comment: Superseeded by deprecation under Issue44874. -- resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

Irit Katriel added the comment: Re GH-20104 - What I did there was to simply revert the change that git bisect showed caused my segfault. It's been a year since then, and I don't understand this stuff well enough to say that reverting this brings us to a good state, with respect to

[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

Łukasz Langa added the comment: Agreed with Irit. GH-12607 is conflicting with `main` and in an unclear review state. Irit's got both GH-20104 which fixes the segfault and GH-27693 which deprecates the old macros. It's sad we missed the train for either GH-20104 or the original GH-12607 to

[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

Change by Irit Katriel : -- versions: +Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

Irit Katriel added the comment: There has been no progress on PR12607. I think we should at least deprecate Py_TRASHCAN_SAFE_BEGIN/END in 3.10 and tell people to use Py_TRASHCAN_BEGIN/END instead. -- ___ Python tracker

[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

Pablo Galindo Salgado added the comment: I think that we should try to land PR 12607 first. -- ___ Python tracker ___ ___

[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

Irit Katriel added the comment: I've confirmed that my test still segfaults on master, but if I take the Py_TRASHCAN_SAFE_BEGIN(op) from PR 12607 then it doesn't segfault. -- versions: +Python 3.10, Python 3.9 -Python 3.8 ___ Python tracker

[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

Pablo Galindo Salgado added the comment: Hi Irit, Could you kindly check if PR 12607 solves this issue in any way? -- ___ Python tracker ___

[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

Irit Katriel added the comment: Have you had a chance to look into this? It took some debugging to get to the bottom of this problem in our system (nothing in the "what's new in python 3.8" doc gave any hint). The solution I went for was to replace the old macros with the new ones. If

[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

Change by Irit Katriel : -- pull_requests: +19412 pull_request: https://github.com/python/cpython/pull/20104 ___ Python tracker ___

[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

Change by Irit Katriel : -- keywords: +patch pull_requests: +19411 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20103 ___ Python tracker ___

[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

Jeroen Demeyer added the comment: I need to check, but I think this is a duplicate of bpo-35983, which still has PR 12607 open. -- ___ Python tracker ___

[issue40608] PY3.8 GC segfault (Py_TRASHCAN_SAFE_BEGIN/END are not backwards compatible)

New submission from Irit Katriel : While migrating our codebase from python 3.7 to python 3.8, one of our unit tests segfaulted and I’ve narrowed it down to the change of typeobject.c in: commit 351c67416ba4451eb3928fa0b2e933c2f25df1a3 Author: Jeroen Demeyer Date: Fri May 10 19:21:11