[issue40648] File mode is not tested on Windows

[Terry J. Reedy]

Change by Terry J. Reedy :


--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
versions: +Python 3.10 -Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40648] File mode is not tested on Windows

[Pavol Babinčák]

Change by Pavol Babinčák :


--
keywords: +patch
pull_requests: +19435
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/20130

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40648] File mode is not tested on Windows

[Pavol Babinčák]

New submission from Pavol Babinčák :

>From what I can tell only place where file mode is tested is test_mode() 
>method of class TestFilemode in test_stat.py. Relevant section for Windows 
>(os.name != 'posix'):

with open(TESTFN, 'w'):
  pass

...

os.chmod(TESTFN, 0o700)
st_mode, modestr = self.get_mode()
self.assertEqual(modestr[:3], '-rw')
self.assertS_IS("REG", st_mode)
self.assertEqual(self.statmod.S_IFMT(st_mode),
 self.statmod.S_IFREG)

Doesn't test that files under Windows can have only two modes:
- 0o444 - If os.chmod() is missing stat.S_IWRITE. Effectively readonly.
- 0o666 - Regular file by default.

On the top of that I believe last two assertions are equivalent - test file is 
regular. But that would be for a different issue, I guess.

--
components: Tests
messages: 369056
nosy: scrool
priority: normal
severity: normal
status: open
title: File mode is not tested on Windows
type: enhancement
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com