[issue40650] Pytime.c doesn't need to include windows.h

miss-islington added the comment: New changeset ab9d9535aad5e627cb9ae471f186e27a65e48c6e by Miss Islington (bot) in branch '3.8': bpo-40650: Include winsock2.h in pytime.c, instead of a full windows.h (GH-20137)

[issue40650] Pytime.c doesn't need to include windows.h

miss-islington added the comment: New changeset 8e49c1fcf15969ca5c585648a5520617cc0566e6 by Miss Islington (bot) in branch '3.7': bpo-40650: Include winsock2.h in pytime.c, instead of a full windows.h (GH-20137)

[issue40650] Pytime.c doesn't need to include windows.h

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +19488 pull_request: https://github.com/python/cpython/pull/20187 ___ Python tracker

[issue40650] Pytime.c doesn't need to include windows.h

Steve Dower added the comment: Also, for future reference, compile-only changes typically don't require a NEWS entry (since users are not going to be interested in reading it in the changelog, and we have commit messages for developers). We have the ability to skip the requirement on the

[issue40650] Pytime.c doesn't need to include windows.h

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +19489 pull_request: https://github.com/python/cpython/pull/20188 ___ Python tracker

[issue40650] Pytime.c doesn't need to include windows.h

Steve Dower added the comment: New changeset f660567937277cc3a2cd53af77bbb18e905427e8 by Minmin Gong in branch 'master': bpo-40650: Include winsock2.h in pytime.c, instead of a full windows.h (GH-20137) https://github.com/python/cpython/commit/f660567937277cc3a2cd53af77bbb18e905427e8

[issue40650] Pytime.c doesn't need to include windows.h

Change by Steve Dower : -- nosy: -miss-islington resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40650] Pytime.c doesn't need to include windows.h

Steve Dower added the comment: Missing piece of information, it's also _documented_ as being part of the winsock headers: https://docs.microsoft.com/en-us/windows/win32/api/winsock/ns-winsock-timeval Plenty of things get included inadvertently, but they can't be relied upon. In this case

[issue40650] Pytime.c doesn't need to include windows.h

Change by Minmin Gong : -- keywords: +patch pull_requests: +19443 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20137 ___ Python tracker ___

[issue40650] Pytime.c doesn't need to include windows.h

Change by Minmin Gong : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware type: -> enhancement versions: +Python 3.9 ___ Python tracker ___

[issue40650] Pytime.c doesn't need to include windows.h

New submission from Minmin Gong : Python/pytime.c includes windows.h for timeval. But it's not necessary to include the full header, because timeval is defined in winsock headers. -- messages: 369082 nosy: Minmin.Gong priority: normal severity: normal status: open title: Pytime.c