[issue40756] Second argument of LoggerAdapter.__init__ should default to None

[Arturo Escaip]

Arturo Escaip  added the comment:

Done.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40756] Second argument of LoggerAdapter.__init__ should default to None

[Arturo Escaip]

Change by Arturo Escaip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40756] Second argument of LoggerAdapter.__init__ should default to None

[Irit Katriel]

Irit Katriel  added the comment:

looks like this can be closed now?

--
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40756] Second argument of LoggerAdapter.__init__ should default to None

[miss-islington]

miss-islington  added the comment:


New changeset 8ad052464a4e0aef9a11663b80f187087b773592 by Arturo Escaip in 
branch 'master':
bpo-40756: Default second argument of LoggerAdapter.__init__ to None (GH-20362)
https://github.com/python/cpython/commit/8ad052464a4e0aef9a11663b80f187087b773592


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40756] Second argument of LoggerAdapter.__init__ should default to None

[Raymond Hettinger]

Change by Raymond Hettinger :


--
assignee:  -> vinay.sajip
nosy: +vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40756] Second argument of LoggerAdapter.__init__ should default to None

[Arturo Escaip]

Change by Arturo Escaip :


--
keywords: +patch
pull_requests: +19626
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/20362

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40756] Second argument of LoggerAdapter.__init__ should default to None

[Arturo Escaip]

New submission from Arturo Escaip :

The 'extra' argument is not always used by custom logger adapters. There
example:

class IndentAdapter(logging.LoggerAdapter):
def process(self, msg, kwargs):
indent = kwargs.pop(indent, 1)
return ' ' * indent + msg, kwargs

It is cleaner and friendlier to default the 'extra' argument to None
instead of either forcing the subclasses of LoggerAdapter to pass a None
value directly or to override the constructor.

--
components: Library (Lib)
messages: 369815
nosy: arturoescaip
priority: normal
severity: normal
status: open
title: Second argument of LoggerAdapter.__init__ should default to None
type: enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com