[issue40836] logging.fatal() and logging.Logger.fatal() should raise a DeprecationWarning

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40836] logging.fatal() and logging.Logger.fatal() should raise a DeprecationWarning

[miss-islington]

miss-islington  added the comment:


New changeset 25f38d7044a3a47465edd851c4e04f337b2c4b9b by Rémi Lapeyre in 
branch 'master':
bpo-40836: Add docstring to logging.fatal() and logging.Logger.fatal() 
(GH-20563)
https://github.com/python/cpython/commit/25f38d7044a3a47465edd851c4e04f337b2c4b9b


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40836] logging.fatal() and logging.Logger.fatal() should raise a DeprecationWarning

[Rémi Lapeyre]

Rémi Lapeyre  added the comment:

Thanks for the feedback, I updated the PR accordingly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40836] logging.fatal() and logging.Logger.fatal() should raise a DeprecationWarning

[Vinay Sajip]

Vinay Sajip  added the comment:

Yes, they could have a docstring indicating that it is better to use 
critical(). Feel free to update the PR along that line.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40836] logging.fatal() and logging.Logger.fatal() should raise a DeprecationWarning

[Rémi Lapeyre]

Rémi Lapeyre  added the comment:

Thanks, I was wondering about that. I didn't know what is the status of the 
function exactly and found https://bugs.python.org/msg344080.

While they are not documented, you can find them in dir() and in the help, 
maybe they should have a docstring?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40836] logging.fatal() and logging.Logger.fatal() should raise a DeprecationWarning

[Vinay Sajip]

Vinay Sajip  added the comment:

Well, I'm not planning to actually deprecate and then remove them - as they're 
not documented, it's unlikely that new code will use them, and there's no 
particular reason to break old code that happens to use them.

--
nosy: +vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40836] logging.fatal() and logging.Logger.fatal() should raise a DeprecationWarning

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
keywords: +patch
pull_requests: +19804
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/20563

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40836] logging.fatal() and logging.Logger.fatal() should raise a DeprecationWarning

[Rémi Lapeyre]

New submission from Rémi Lapeyre :

Both are not documented and synonymous for critical() but don't raise a 
DeprecationWarning.

--
components: Library (Lib)
messages: 370522
nosy: remi.lapeyre
priority: normal
severity: normal
status: open
title: logging.fatal() and logging.Logger.fatal() should raise a 
DeprecationWarning
versions: Python 3.10, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com