[issue40939] Remove the old parser

Petr Viktorin added the comment: New changeset dc10264eb880ed63fcf42c17057f3f5d879a0a0c by Miss Islington (bot) in branch '3.10': bpo-40939: Remove documentation for `PyParser_*` & add porting notes (GH-26855) (GH-26898)

[issue40939] Remove the old parser

Change by miss-islington : -- pull_requests: +25474 pull_request: https://github.com/python/cpython/pull/26898 ___ Python tracker ___

[issue40939] Remove the old parser

Petr Viktorin added the comment: New changeset 29987f72650b7cccee4df216c8297e8484a44e6a by Petr Viktorin in branch 'main': bpo-40939: Remove documentation for `PyParser_*` & add porting notes (GH-26855) https://github.com/python/cpython/commit/29987f72650b7cccee4df216c8297e8484a44e6a

[issue40939] Remove the old parser

Petr Viktorin added the comment: - The removed functions are still listed in the documentation; this is confusing. - `struct _node` is not very usable in the C API, but what I saw in mod_wsgi was giving gave PyParser_* output to PyNode_Compile. I tried to write porting notes for this

[issue40939] Remove the old parser

Change by Petr Viktorin : -- nosy: +petr.viktorin nosy_count: 11.0 -> 12.0 pull_requests: +25434 pull_request: https://github.com/python/cpython/pull/26855 ___ Python tracker

[issue40939] Remove the old parser

STINNER Victor added the comment: FYI the unbound project was fixed by calling Py_CompileString() on Python 3.9 and newer: https://github.com/NLnetLabs/unbound/commit/e0d426ebb10653a78bf5c4053198f6ac19bfcd3e -- ___ Python tracker

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: Opened https://bugs.python.org/issue42545 for that -- ___ Python tracker ___ ___

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: > On Windows there is PC/python3dll.c. Even that is severely out of date, unfortunately. There are many functions that were removed in 3.8 and 3.7 that are still listed there. -- ___ Python tracker

[issue40939] Remove the old parser

Nikita Nemkin added the comment: > Unfortunately there is no official maintained list if those symbols, so is > taking a while On Windows there is PC/python3dll.c. -- ___ Python tracker

[issue40939] Remove the old parser

Igor Skochinsky added the comment: > I am currently working on test that checks that the stable API symbols are > correctly exported. Thank you very much! For added motivation, the 3.8.0 release was unusable thanks to issue37633 which was somewhat similar (also in pythonrun). For

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: I am currently working on test that checks that the stable API symbols are correctly exported. Unfortunately there is no official maintained list if those symbols, so is taking a while -- ___ Python

[issue40939] Remove the old parser

Igor Skochinsky added the comment: Thanks for the fix! I'd like to submit a test to avoid this and similar issues in future. Are there any guidelines for this? Sorry if this is a wrong place to ask. -- ___ Python tracker

[issue40939] Remove the old parser

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: New changeset 46bd5ed94cf3d5e03f45eecf9afea1659980c8bf by Pablo Galindo in branch 'master': bpo-40939: Restore some stable API functions incorrectly deleted (GH-23606) https://github.com/python/cpython/commit/46bd5ed94cf3d5e03f45eecf9afea1659980c8bf

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: Seems that commit 1ed83adb0e95305af858bd41af531e487f54fee7 was deleting some functions that were not correctly covered by redirection macros. I have opened PR 23606 to restore those as they were. -- ___

[issue40939] Remove the old parser

Change by Pablo Galindo Salgado : -- pull_requests: +22474 pull_request: https://github.com/python/cpython/pull/23606 ___ Python tracker ___

[issue40939] Remove the old parser

Guido van Rossum added the comment: Hm, I wonder if there's a typo here in pythonrun.c: /* For use in Py_LIMITED_API */ #undef Py_CompileString PyObject * PyCompileString(const char *str, const char *filename, int start) { return Py_CompileStringFlags(str, filename, start, NULL); }

[issue40939] Remove the old parser

Igor Skochinsky added the comment: Attached is a sample program which works on 3.9 but fails linking with 3.10.0a2 The .so is missing the symbol: igor@LAPTOP:~/py_limited_api_example$ nm /home/igor/lib/libpython3.9.so | grep Py_CompileString 00212720 T Py_CompileString

[issue40939] Remove the old parser

Igor Skochinsky added the comment: > But Py_CompileString() function was not removed, it's still in the master > branch (future Python 3.10). Why do you think that it has been removed? Thank you. It looked that way because of the removed block of lines in the commit

[issue40939] Remove the old parser

STINNER Victor added the comment: > It seems this patch removes some functions provided by the Stable ABI (PEP > 384), most notably Py_CompileString. Was this the intention? If not, is there > still a chance to reintroduce it before the release? The functions removal is intentional and was

[issue40939] Remove the old parser

Igor Skochinsky added the comment: Hi All, It seems this patch removes some functions provided by the Stable ABI (PEP 384), most notably Py_CompileString. Was this the intention? If not, is there still a chance to reintroduce it before the release? -- nosy: +Igor.Skochinsky

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: > This code is non-trivial :-( Should we provide a *new* C function doing that? We could discuss adding a new C function, but IMHO that code is not especially horrible or unreadable. I agree it could be simpler, though. --

[issue40939] Remove the old parser

STINNER Victor added the comment: We should check of the 3 mentioned projects (mod_wsgi, kdevelop-python, unbound) use the removed functions to suggest a similar replacement. I understood that there is no drop-in replacement. unbound does not use to get the parsed Python code as CST, but

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: > The removals are documented, but the developers who are affected have no clue > what to do. What do you think? Here is difficult to recommend a canonical Path because as I mentioned, there is no replacement for these functions because that

[issue40939] Remove the old parser

Miro Hrončok added the comment: Thanks. I feel like the What's new document should teach people what to do when they are hit by the removals. The removals are documented, but the developers who are affected have no clue what to do. What do you think? (Sorry I wasn't able to provide this

[issue40939] Remove the old parser

Lysandros Nikolaou added the comment: Victor, Miro, both removal of the parser module and of all the C API functions are now documented in the 3.10 whatsnew document. Do you feel that this is enough for us to close this issue again? -- ___ Python

[issue40939] Remove the old parser

miss-islington added the comment: New changeset c26d5916d68c47a20dd941f9e89afdaf85b2711e by Lysandros Nikolaou in branch 'master': bpo-40939: Document removal of the old parser in 3.10 whatsnew (GH-23321) https://github.com/python/cpython/commit/c26d5916d68c47a20dd941f9e89afdaf85b2711e

[issue40939] Remove the old parser

Change by Lysandros Nikolaou : -- pull_requests: +22212 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/23321 ___ Python tracker ___

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: > Pablo, have you already started on this? I didn't see your comment earlier > and I've got a PR ready. Yeah, but don't worry: submit your PR and I will review it :) -- ___ Python tracker

[issue40939] Remove the old parser

Lysandros Nikolaou added the comment: Pablo, have you already started on this? I didn't see your comment earlier and I've got a PR ready. -- ___ Python tracker ___

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: I will submit a PR today -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue40939] Remove the old parser

STINNER Victor added the comment: Please also document the removal of the node.h header file. The removal of this file broke the build of the two following packages. mod_wsgi: https://bugzilla.redhat.com/show_bug.cgi?id=1898158 In file included from src/server/mod_wsgi.c:22:

[issue40939] Remove the old parser

Miro Hrončok added the comment: Could the removal of the parser module be documented in https://docs.python.org/3.10/whatsnew/3.10.html please? -- nosy: +hroncok ___ Python tracker

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: > By the way, is there a replacement for this function? The unbound project > uses it to display a SyntaxError when PyRun_SimpleFile() fails. There is no replacement for the function because that function returned CST nodes and those not exist

[issue40939] Remove the old parser

Guido van Rossum added the comment: Honestly that code seems poorly thought out. If running it returns -1, an exception was presumably reported, but not necessarily SyntaxError -- so parsing it may not produce an error at all. The functionality needed is in PyRun_InteractiveOneObjectEx(),

[issue40939] Remove the old parser

STINNER Victor added the comment: > There is no mention of PyParser_SimpleParseFile() removal in What's New in > Python 3.10. By the way, is there a replacement for this function? The unbound project uses it to display a SyntaxError when PyRun_SimpleFile() fails. Petr Menšík asked: "Could

[issue40939] Remove the old parser

STINNER Victor added the comment: I reopen the issue. Would you mind to explicitly list function removed from the C API in What's New in Python 3.10? https://docs.python.org/dev/whatsnew/3.10.html#id4 I'm talking about the commit 1ed83adb0e95305af858bd41af531e487f54fee7. For example, the

[issue40939] Remove the old parser

Terry J. Reedy added the comment: New changeset 5a8364780b7e881385f6fabcf072d599e80f51b8 by Terry Jan Reedy in branch 'master': bpo-41808: Add What's New 3.9 entry missing from master (#22294) https://github.com/python/cpython/commit/5a8364780b7e881385f6fabcf072d599e80f51b8 --

[issue40939] Remove the old parser

Change by Terry J. Reedy : -- nosy: +terry.reedy nosy_count: 8.0 -> 9.0 pull_requests: +21347 pull_request: https://github.com/python/cpython/pull/22294 ___ Python tracker ___

[issue40939] Remove the old parser

miss-islington added the comment: New changeset b3fbff7289176ba1a322e6899c3d4a04880ed5a7 by Lysandros Nikolaou in branch 'master': bpo-40939: Remove even more references to the old parser (GH-21642) https://github.com/python/cpython/commit/b3fbff7289176ba1a322e6899c3d4a04880ed5a7

[issue40939] Remove the old parser

Guido van Rossum added the comment: New changeset e6b2d93f0c3891827f609ecac1ced21e1626ed0a by Guido van Rossum in branch '3.9': [3.9] bpo-40939: Use the new grammar for the grammar specification documentation (GH-19969) (#21641)

[issue40939] Remove the old parser

Change by Lysandros Nikolaou : -- pull_requests: +20783 pull_request: https://github.com/python/cpython/pull/21642 ___ Python tracker ___

[issue40939] Remove the old parser

Guido van Rossum added the comment: The old parser is completely gone from the 3.10 branch. Closing. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue40939] Remove the old parser

Change by Guido van Rossum : -- pull_requests: +20782 pull_request: https://github.com/python/cpython/pull/21641 ___ Python tracker ___

[issue40939] Remove the old parser

Guido van Rossum added the comment: New changeset 72cabb2aa636272e608285f5a6ba83b62be9be4e by Pablo Galindo in branch 'master': bpo-40939: Use the new grammar for the grammar specification documentation (GH-19969)

[issue40939] Remove the old parser

Change by Pablo Galindo Salgado : -- pull_requests: +20774 pull_request: https://github.com/python/cpython/pull/19969 ___ Python tracker ___

[issue40939] Remove the old parser

Guido van Rossum added the comment: See also https://github.com/python/cpython/pull/19969 (Pablo's attempt at replacing the grammar in the reference docs with something derived from Grammar/python.gram). -- ___ Python tracker

[issue40939] Remove the old parser

Change by Guido van Rossum : -- pull_requests: +20765 pull_request: https://github.com/python/cpython/pull/21624 ___ Python tracker ___

[issue40939] Remove the old parser

Guido van Rossum added the comment: There are some difficulties with removing Grammar/Grammar, since it is used to generate the full grammar in the reference docs (Doc/reference/grammar.rst). Producing a similar grammar from the PEG grammar is currently painful because our PEG grammar

[issue40939] Remove the old parser

Ned Deily added the comment: New changeset 8d02f91dc6139a13b6efa9bd5a5b4bdd7ddcc29d by Ned Deily in branch 'master': bpo-40939: run autoreconf to fix configure{,.ac} disparity (GH-21152) https://github.com/python/cpython/commit/8d02f91dc6139a13b6efa9bd5a5b4bdd7ddcc29d --

[issue40939] Remove the old parser

Change by Ned Deily : -- nosy: +ned.deily nosy_count: 7.0 -> 8.0 pull_requests: +20311 pull_request: https://github.com/python/cpython/pull/21152 ___ Python tracker ___

[issue40939] Remove the old parser

miss-islington added the comment: New changeset 8ae5e8ec8147e6434454e66953c25848b848711a by Lysandros Nikolaou in branch '3.9': [3.9] bpo-40939: Deprecate PyNode_Compile (GH-21036) https://github.com/python/cpython/commit/8ae5e8ec8147e6434454e66953c25848b848711a --

[issue40939] Remove the old parser

Lysandros Nikolaou added the comment: Thanks Victor for the catch! I've opened a PR that deprecates PyNode_Compile in 3.9. -- ___ Python tracker ___

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: New changeset 564cd187677ae8d1488c4d8ae649aea34ebbde07 by Lysandros Nikolaou in branch 'master': bpo-40939: Rename PyPegen* functions to PyParser* (GH-21016) https://github.com/python/cpython/commit/564cd187677ae8d1488c4d8ae649aea34ebbde07

[issue40939] Remove the old parser

Change by Lysandros Nikolaou : -- pull_requests: +20207 pull_request: https://github.com/python/cpython/pull/21036 ___ Python tracker ___

[issue40939] Remove the old parser

STINNER Victor added the comment: > bpo-40939: Remove the old parser (Part 2) (GH-21005) This change removes PyNode_Compile() which is part of the public C API. Would you mind to also deprecate it, as you did for PyParser_xxx() functions? -- ___

[issue40939] Remove the old parser

Change by Pablo Galindo Salgado : -- pull_requests: +20197 pull_request: https://github.com/python/cpython/pull/21025 ___ Python tracker ___

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: New changeset d301d9473e9a9b78d6e6678e9fe5ef66d46084e1 by Lysandros Nikolaou in branch '3.9': [3.9] bpo-40939: Deprecate the PyParser_SimpleParse* functions (GH-21012) https://github.com/python/cpython/commit/d301d9473e9a9b78d6e6678e9fe5ef66d46084e1

[issue40939] Remove the old parser

Change by Lysandros Nikolaou : -- pull_requests: +20190 pull_request: https://github.com/python/cpython/pull/21016 ___ Python tracker ___

[issue40939] Remove the old parser

Change by Lysandros Nikolaou : -- pull_requests: +20186 pull_request: https://github.com/python/cpython/pull/21012 ___ Python tracker ___

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: New changeset 314858e2763e76e77029ea0b691d749c32939087 by Lysandros Nikolaou in branch 'master': bpo-40939: Remove the old parser (Part 2) (GH-21005) https://github.com/python/cpython/commit/314858e2763e76e77029ea0b691d749c32939087 --

[issue40939] Remove the old parser

Change by Lysandros Nikolaou : -- pull_requests: +20179 pull_request: https://github.com/python/cpython/pull/21005 ___ Python tracker ___

[issue40939] Remove the old parser

Guido van Rossum added the comment: You can delete symbol.py -- it has no use now that the old parser is gone. We should probably also update the regeneration targets in the Makefile. (At least review them.) -- ___ Python tracker

[issue40939] Remove the old parser

Lysandros Nikolaou added the comment: I'm currently testing a commit that removes all these files on my fork, before I push it upstream. A question that I'm not 100% sure about is if we can already remove the symbol module. I guess it's okay since it got deprecated in 3.9 (bpo-40759) and

[issue40939] Remove the old parser

Nikita Nemkin added the comment: Shouldn't the following files be deleted too? Include/bitset.h Include/grammar.h Include/graminit.h Include/parsetok.h Include/node.h Python/graminit.c Parser/node.c Also declarations: PyNode_Compile in Include/compile.h PyParser_SimpleParse* in

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: New changeset 756180b4bfa09bb77394a2b3754d331181d4f28c by Pablo Galindo in branch 'master': bpo-40939: Clean and adapt the peg_generator directory after deleting the old parser (GH-20822)

[issue40939] Remove the old parser

Change by Pablo Galindo Salgado : -- pull_requests: +20018 pull_request: https://github.com/python/cpython/pull/20822 ___ Python tracker ___

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: New changeset 3782497cc22e70b41e32ac09cb06d3948074d8a7 by Pablo Galindo in branch '3.9': [3.9] bpo-40939: Fix test_keyword for the old parser (GH-20814) https://github.com/python/cpython/commit/3782497cc22e70b41e32ac09cb06d3948074d8a7 --

[issue40939] Remove the old parser

Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40939] Remove the old parser

miss-islington added the comment: New changeset 436b648910c27baf8164a6d46d746d36d8a93478 by Pablo Galindo in branch 'master': bpo-40939: Remove some extra references to PYTHONOLDPARSER (GH-20815) https://github.com/python/cpython/commit/436b648910c27baf8164a6d46d746d36d8a93478 --

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: > A few remaining references to the good old times of the old parser: Thanks Victor, opened https://github.com/python/cpython/pull/20815 to address those. -- ___ Python tracker

[issue40939] Remove the old parser

Change by Pablo Galindo Salgado : -- pull_requests: +20013 pull_request: https://github.com/python/cpython/pull/20815 ___ Python tracker ___

[issue40939] Remove the old parser

Change by Pablo Galindo Salgado : -- pull_requests: +20012 pull_request: https://github.com/python/cpython/pull/20814 ___ Python tracker ___

[issue40939] Remove the old parser

STINNER Victor added the comment: A few remaining references to the good old times of the old parser: Programs/_testembed.c:488:putenv("PYTHONOLDPARSER=1"); Programs/_testembed.c:676:putenv("PYTHONOLDPARSER=1"); Tools/scripts/run_tests.py:29:if 'PYTHONOLDPARSER' not in os.environ:

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: New changeset 1ed83adb0e95305af858bd41af531e487f54fee7 by Pablo Galindo in branch 'master': bpo-40939: Remove the old parser (GH-20768) https://github.com/python/cpython/commit/1ed83adb0e95305af858bd41af531e487f54fee7 --

[issue40939] Remove the old parser

Guido van Rossum added the comment: New changeset bcd7deed9118e365c1225de2a2e1a81bf988c6ab by Lysandros Nikolaou in branch 'master': bpo-40939: Remove PEG parser easter egg (__new_parser__) (#20802) https://github.com/python/cpython/commit/bcd7deed9118e365c1225de2a2e1a81bf988c6ab

[issue40939] Remove the old parser

Lysandros Nikolaou added the comment: > This change broke this buildbot: GH-20802 fixes this breakage. -- ___ Python tracker ___

[issue40939] Remove the old parser

Lysandros Nikolaou added the comment: > Lysandros can you modify PR 20802 to remove it? Yup! -- ___ Python tracker ___ ___

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: Ok, let's remove it. Lysandros can you modify PR 20802 to remove it? -- ___ Python tracker ___

[issue40939] Remove the old parser

STINNER Victor added the comment: > New changeset 961edf7979ca34d6fe104a1cce005aa8cac35821 by Miss Islington > (bot) in branch '3.9': > bpo-40939: Generate keyword.py using the new parser (GH-20800) This change broke this buildbot: AMD64 Arch Linux VintageParser 3.9:

[issue40939] Remove the old parser

Guido van Rossum added the comment: Honestly I see no reason to keep that easter egg. Can we remove it please? -- ___ Python tracker ___

[issue40939] Remove the old parser

STINNER Victor added the comment: I did'nt ask to remove the easter egg. I'm just asking to avoid the "new" name. In my experience, each time that a "new" thing happens, later we have to use "new extended", "new_v2" or worse name :-) Oh, if the name changes, please change it in 3.9 as well.

[issue40939] Remove the old parser

Change by Lysandros Nikolaou : -- pull_requests: +19998 pull_request: https://github.com/python/cpython/pull/20802 ___ Python tracker ___

[issue40939] Remove the old parser

Lysandros Nikolaou added the comment: > I would personally would like to keep the easter egg, but I assume is better > to rename it to "__peg_parser__". Ok then! On it. -- ___ Python tracker

[issue40939] Remove the old parser

miss-islington added the comment: New changeset 961edf7979ca34d6fe104a1cce005aa8cac35821 by Miss Islington (bot) in branch '3.9': bpo-40939: Generate keyword.py using the new parser (GH-20800) https://github.com/python/cpython/commit/961edf7979ca34d6fe104a1cce005aa8cac35821 --

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: > I guess we could just remove this, as soon as the old parser is out. We were > only using this to differentiate between the two parsers, when we were > testing enabling/disabling the old one. I could get a PR ready to be merged > after GH-20768 is

[issue40939] Remove the old parser

Lysandros Nikolaou added the comment: > Can we rename the keyword to "__peg_parser__"? I guess we could just remove this, as soon as the old parser is out. We were only using this to differentiate between the two parsers, when we were testing enabling/disabling the old one. I could get a PR

[issue40939] Remove the old parser

STINNER Victor added the comment: >>> __new_parser__ File "", line 1 __new_parser__ ^ SyntaxError: You found it! "new", "ex" or "ng" are not really future proof names. Can we rename the keyword to "__peg_parser__"? -- nosy: +vstinner

[issue40939] Remove the old parser

Pablo Galindo Salgado added the comment: New changeset 9727694f08cad4b019d2939224e3416312b1c0e1 by Lysandros Nikolaou in branch 'master': bpo-40939: Generate keyword.py using the new parser (GH-20800) https://github.com/python/cpython/commit/9727694f08cad4b019d2939224e3416312b1c0e1

[issue40939] Remove the old parser

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +19997 pull_request: https://github.com/python/cpython/pull/20801 ___ Python tracker

[issue40939] Remove the old parser

Change by Lysandros Nikolaou : -- pull_requests: +19996 pull_request: https://github.com/python/cpython/pull/20800 ___ Python tracker ___

[issue40939] Remove the old parser

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +19972 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20768 ___ Python tracker

[issue40939] Remove the old parser

Change by Pablo Galindo Salgado : -- nosy: +gvanrossum, lys.nikolaou ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue40939] Remove the old parser

New submission from Pablo Galindo Salgado : As stated in PEP 617, the old parser will be removed in Python 3.10 -- assignee: pablogsal components: Interpreter Core messages: 371182 nosy: pablogsal priority: normal severity: normal status: open title: Remove the old parser versions: