[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Vinay Sajip]

Vinay Sajip  added the comment:

Thanks for the PR. I reviewed it and requested changes about 3 weeks ago - you 
should have received a notification from GitHub when that happened.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Brett Hannigan]

Brett Hannigan  added the comment:

Just wanted to check-in to see if there were any updates on my proposed PR?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Brett Hannigan]

Brett Hannigan  added the comment:

O.K. CLA is now signed and if I check on the "check-yourself" with my github 
user it is showing that I have signed it now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Brett Hannigan]

Brett Hannigan  added the comment:

Thanks.

I don't know why it still says CLA not signed - I signed it a week ago, but 
I'll try to figure that out this week.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Vinay Sajip]

Vinay Sajip  added the comment:

OK, seems like a reasonable use case. I haven't looked at the PR yet, as it 
still has a "CLA not signed" label, and I normally wait until the CLA is signed 
before looking more closely at PRs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Brett Hannigan]

Brett Hannigan  added the comment:

I encountered the need for the iterators when trying to create a subclass of 
the QueueHandler class that would manage both the QueueHandler and the 
QueueListener. The implementation is very similar to that described in this 
Medium post:
https://medium.com/@rob.blackbourn/how-to-use-python-logging-queuehandler-with-dictconfig-1e8b1284e27a

Both the original poster and I encountered one small issue: when using a 
dictConfig to instantiate the new subclass, the main QueueHandler gets a 
ConvertingList of the handlers that the user has requested be used. The 
subclass would then pass these to the QueueListener, but the constructor for 
the QueueListener takes *handlers (that is, it will convert the ConvertingList 
to a tuple). Unfortunately, because ConvertingList does not expose the 
iterator, converting from the ConvertingList to the tuple results in a tuple of 
unconverted handler references (ultimately strings).

The author of the Medium article gets around this by creating a little function 
that simply loops over the length of the ConvertingList and does a "get" on 
each item on the list, to ensure that the item is converted. Since 
ConvertingList is not documented though, there is concern that this approach 
could break in the future if the interface changes etc. 

With the implementation of the iterator in this PR, the conversion of the 
ConvertingList to the tuple will automatically result in a tuple of converted 
handlers, so one doesn't need to know about the ConvertingList object - it 
handles things behind the scenes.

Here is the code that the Medium article currently uses to force conversion:

def _resolve_handlers(l):
if not isinstance(l, ConvertingList):
return l

# Indexing the list performs the evaluation.
return [l[i] for i in range(len(l))]

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Vinay Sajip]

Vinay Sajip  added the comment:

> If it is not goal

I don't have a goal to make these part of a documented API. OP, can you share a 
use case where you need to iterate over these internal structures?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

If you are going to make them public general purpose classes you need to 
implement also support of slices, __reversed__(), index(), remove(), count(), 
sort(), copy() in ConvertingList and more methods in ConvertingTuple, and 
ConvertingDict.

If it is not goal then I think that no any changes are needed. If they are 
internal classes they needed only features which are used internally by the 
module code.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Vinay Sajip]

Vinay Sajip  added the comment:

> I think the other issue here is that the ConvertingX classes aren't 
> documented apart from comments in the code where they are defined.

That's deliberate - they're considered an internal implementation detail.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Michael DePalatis]

Michael DePalatis  added the comment:

I think the other issue here is that the ConvertingX classes aren't documented 
apart from comments in the code where they are defined.

--
nosy: +mivade

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Brett Hannigan]

Change by Brett Hannigan :


--
versions:  -Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Vinay Sajip]

Vinay Sajip  added the comment:

This is a change in behaviour, so probably needs to be added to future versions 
only.

--
nosy: +vinay.sajip
versions: +Python 3.10 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
nosy: +python-dev
nosy_count: 1.0 -> 2.0
pull_requests: +20398
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/21248

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41177] ConvertingList and ConvertingTuple lack iterators and ConvertingDict lacks items()

[Brett Hannigan]

New submission from Brett Hannigan :

The logging.config module uses three internal data structures to hold items 
that may need to be converted to a handler or other object: ConvertingList, 
ConvertingTuple, and ConvertingDict.

These three objects provide interfaces to get converted items using the 
__getitem__ methods. However, if a user tries to iterate over items in the 
container, they will get the un-converted entries.

--
components: Library (Lib)
messages: 372724
nosy: Brett Hannigan
priority: normal
severity: normal
status: open
title: ConvertingList and ConvertingTuple lack iterators and ConvertingDict 
lacks items()
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com