[issue41207] distutils.command.build_ext raises FileNotFoundError

STINNER Victor added the comment: I close the issue since it's fixed. I also reset the priority. -- priority: release blocker -> resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue41207] distutils.command.build_ext raises FileNotFoundError

miss-islington added the comment: New changeset 2c82628e9aa2af4b662e92e227618859675dd726 by Miss Islington (bot) in branch '3.9': bpo-41207 In distutils.spawn, rewrite FileNotFound (GH-21359) https://github.com/python/cpython/commit/2c82628e9aa2af4b662e92e227618859675dd726 --

[issue41207] distutils.command.build_ext raises FileNotFoundError

Change by miss-islington : -- pull_requests: +20517 pull_request: https://github.com/python/cpython/pull/21373 ___ Python tracker ___

[issue41207] distutils.command.build_ext raises FileNotFoundError

miss-islington added the comment: New changeset 6ae2780be0667a8dc52c4fb583171ec86067d700 by Jason R. Coombs in branch 'master': bpo-41207 In distutils.spawn, rewrite FileNotFound (GH-21359) https://github.com/python/cpython/commit/6ae2780be0667a8dc52c4fb583171ec86067d700 -- nosy:

[issue41207] distutils.command.build_ext raises FileNotFoundError

Change by Jason R. Coombs : -- keywords: +patch pull_requests: +20504 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21359 ___ Python tracker ___

[issue41207] distutils.command.build_ext raises FileNotFoundError

Jason R. Coombs added the comment: I learned the magical incantation to port commits from pypa/distutils to CPython: ``` cpython bugfix/41207-rewrite-filenotfound $ git -C ~/p/pypa/distutils format-patch HEAD~2 --stdout | git am --directory Lib Applying: Add

[issue41207] distutils.command.build_ext raises FileNotFoundError

Jason R. Coombs added the comment: Sure. I'll submit patches. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue41207] distutils.command.build_ext raises FileNotFoundError

STINNER Victor added the comment: > Programs trapping CompileError but not FileNotFoundError will crash where > once they had error handling. Do you mean mean that spawn() of distutils.spawn should catch FileNotFoundError and raise a CompilerError instead? It seems like before my commit

[issue41207] distutils.command.build_ext raises FileNotFoundError

Łukasz Langa added the comment: Good catch! The unification change is 3.10 only but I'm totally fine accepting the _compile fix in Python 3.9. -- ___ Python tracker ___

[issue41207] distutils.command.build_ext raises FileNotFoundError

Jason R. Coombs added the comment: CPython should also consider [this change](https://github.com/pypa/distutils/commit/d9ba43436d), which unifies the `DEBUG` handling, consolidates the exception trapping, and uses `subprocess.check_call` to re-use exit code checking. --

[issue41207] distutils.command.build_ext raises FileNotFoundError

Jason R. Coombs added the comment: In [pypa/distutils@7aa5abeafc](https://github.com/pypa/distutils/commit/7aa5abeafc1e0b1b351c4c8ac7eb14c310366a46), I've pushed a fix (with a repro test in the parent commit). I recommend this fix be applied to CPython 3.9. --

[issue41207] distutils.command.build_ext raises FileNotFoundError

Change by Jason R. Coombs : -- versions: +Python 3.10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41207] distutils.command.build_ext raises FileNotFoundError

New submission from Jason R. Coombs : In [pypa/setuptools#2228](https://github.com/pypa/setuptools/issues/2228), by adopting the distutils codebase from a late release of CPython, Setuptools stumbled onto an API-breaking change in distutils rooted at issue39763. Details are in the Setuptools