[issue41374] socket.TCP_* no longer available with cygwin 3.1.6+

[Irit Katriel]

Change by Irit Katriel :


--
resolution: duplicate -> fixed
status: open -> closed
superseder: Cygwin is unsupported - close all open issues and list them here. 
-> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41374] socket.TCP_* no longer available with cygwin 3.1.6+

[Irit Katriel]

Change by Irit Katriel :


--
versions: +Python 3.11 -Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41374] socket.TCP_* no longer available with cygwin 3.1.6+

[Irit Katriel]

Irit Katriel  added the comment:


New changeset d8e181925123ab1fd3dfcad3b29325b2b0ff704b by Zackery Spytz in 
branch 'main':
bpo-41374: Remove obsolete exclusion of netinet/tcp.h on Cygwin (GH-21649)
https://github.com/python/cpython/commit/d8e181925123ab1fd3dfcad3b29325b2b0ff704b


--
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41374] socket.TCP_* no longer available with cygwin 3.1.6+

[Irit Katriel]

Change by Irit Katriel :


--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41374] socket.TCP_* no longer available with cygwin 3.1.6+

[Irit Katriel]

Change by Irit Katriel :


--
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder:  -> Cygwin is unsupported - close all open issues and list them 
here.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41374] socket.TCP_* no longer available with cygwin 3.1.6+

[Christoph Reiter]

Christoph Reiter  added the comment:

ping. The PR looks good to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41374] socket.TCP_* no longer available with cygwin 3.1.6+

[Marco Atzeri]

Marco Atzeri  added the comment:

The Analysis is correct. 
Removing the test for CYGWIN and always include the 


solved the problem building all python (3.6,3.7,3.8) packages

https://sourceware.org/pipermail/cygwin-apps/2020-December/040845.html
https://sourceware.org/pipermail/cygwin-announce/2020-December/009853.html

attached patch used on the build.
Similar one was applied to the rebuild of 2.7.18

--
nosy: +matzeri
versions: +Python 3.6, Python 3.7
Added file: https://bugs.python.org/file49717/3.6.12-socketmodule.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41374] socket.TCP_* no longer available with cygwin 3.1.6+

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
nosy: +ZackerySpytz
nosy_count: 2.0 -> 3.0
pull_requests: +20789
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/21649

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41374] socket.TCP_* no longer available with cygwin 3.1.6+

[Christoph Reiter]

Change by Christoph Reiter :


--
nosy: +erik.bray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41374] socket.TCP_* no longer available with cygwin 3.1.6+

[Christoph Reiter]

New submission from Christoph Reiter :

The TCP macros are provided by netinet/tcp.h, which for some reason is skipped 
here: 
https://github.com/python/cpython/blob/592527f3ee59616eca2bd1da771f7c14cee808d5/Modules/socketmodule.h#L11

Until cygwin 3.1.6 these macros were also provided by sys/socket.h, but this 
got removed in 
https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=e037192b505b4f233fca9a6deafc9797210f6693

This leads to socket.TCP_NODELAY for example not being available anymore.

git blame leads me to 
https://github.com/python/cpython/commit/b5daaed30d7c54ba1f516289f3a7a30a864133af
 introducing this special case, which isn't very helpful. I'd suggest to just 
remove the cygwin check and always include it (which works fine on my machine)

Downstream bug report for extra context: 
https://github.com/msys2/MSYS2-packages/issues/2050

--
components: Build
messages: 374126
nosy: lazka
priority: normal
severity: normal
status: open
title: socket.TCP_* no longer available with cygwin 3.1.6+
type: compile error
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com