[issue41498] Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set

[Brett Cannon]

Change by Brett Cannon :


--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41498] Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set

[Christian Heimes]

Change by Christian Heimes :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41498] Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set

[Christian Heimes]

Christian Heimes  added the comment:


New changeset 71b414750eee7af98cc3cee3a64c59d48302a17a by Christian Heimes in 
branch '3.9':
[3.9] bpo-41498: Fix build on platforms without sigset_t (GH-29770) (GH-29774)
https://github.com/python/cpython/commit/71b414750eee7af98cc3cee3a64c59d48302a17a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41498] Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set

[miss-islington]

miss-islington  added the comment:


New changeset 632d589afcaac3b8441c8c042a98e1ae452533e0 by Miss Islington (bot) 
in branch '3.10':
[3.10] bpo-41498: Fix build on platforms without sigset_t (GH-29770) (GH-29773)
https://github.com/python/cpython/commit/632d589afcaac3b8441c8c042a98e1ae452533e0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41498] Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set

[Christian Heimes]

Change by Christian Heimes :


--
pull_requests: +28011
pull_request: https://github.com/python/cpython/pull/29774

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41498] Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set

[Christian Heimes]

Christian Heimes  added the comment:


New changeset dc19e8698327cae3d6274b73c135375955f1d0d0 by Christian Heimes in 
branch 'main':
bpo-41498: Fix build on platforms without sigset_t (GH-29770)
https://github.com/python/cpython/commit/dc19e8698327cae3d6274b73c135375955f1d0d0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41498] Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 4.0 -> 5.0
pull_requests: +28010
pull_request: https://github.com/python/cpython/pull/29773

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41498] Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set

[Christian Heimes]

Change by Christian Heimes :


--
keywords: +patch
nosy: +christian.heimes
nosy_count: 3.0 -> 4.0
pull_requests: +28007
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/29770

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41498] Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set

[Roman Yurchak]

Change by Roman Yurchak :


--
type:  -> compile error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41498] Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set

[Roman Yurchak]

New submission from Roman Yurchak :

The `_Py_Sigset_Converter` function is conditionally defined  in 
https://github.com/python/cpython/blob/777b611c8c5676b80898a429f71d28e59bddc49d/Modules/posixmodule.h#L27
 if `ifdef HAVE_SIGSET_T`

However this function is called unconditionally in 
https://github.com/python/cpython/blob/777b611c8c5676b80898a429f71d28e59bddc49d/Modules/clinic/signalmodule.c.h#L385
 (there are 4 such occurrences), which leads to a compilation error when 
`HAVE_SIGSET_T` is not set.

This is regression in 3.8+ as far as I can tell due to changes in 
https://github.com/python/cpython/pull/6720 

I imagine the solution could be to always define this function but raise an 
exception if it is called when HAVE_SIGSET_T` is undefined, as done in the 
following patch: 
https://github.com/iodide-project/pyodide/blob/fc5495ffdb54a11fd588dc60ba6b8777f90c3724/cpython/patches/0006-fix-Py_Sigset_Converter.patch
 

Would this be acceptable, or is there a better way of handling it? Thanks!

--
messages: 374963
nosy: Roman Yurchak, pablogsal, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set
versions: Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com