[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[Peter Lovett]

Peter Lovett  added the comment:

:-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[Steve Dower]

Steve Dower  added the comment:

Thanks for the report! This should be in the next 3.9 RC.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[Steve Dower]

Steve Dower  added the comment:

Fixes merged, just need Łukasz to confirm it'll be in 3.9.0 and we can resolve 
this.

--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[miss-islington]

miss-islington  added the comment:


New changeset 75c2281762932c4e5f0bd7deae40ef014f704de2 by Miss Islington (bot) 
in branch '3.9':
bpo-41526: Fixed layout of final page of the installer (GH-21871)
https://github.com/python/cpython/commit/75c2281762932c4e5f0bd7deae40ef014f704de2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 7.0 -> 8.0
pull_requests: +20997
pull_request: https://github.com/python/cpython/pull/21872

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[Steve Dower]

Steve Dower  added the comment:


New changeset 6444ca946984c638c67a72aac22fd6d3cc650c16 by Steve Dower in branch 
'master':
bpo-41526: Fixed layout of final page of the installer (GH-21871)
https://github.com/python/cpython/commit/6444ca946984c638c67a72aac22fd6d3cc650c16


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[Steve Dower]

Change by Steve Dower :


--
keywords: +patch
pull_requests: +20996
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/21871

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[Steve Dower]

Steve Dower  added the comment:

Thanks, Mark. We shall not hold you solely responsible for the port any longer 
;)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[Mark Hammond]

Mark Hammond  added the comment:

Yes, while I appreciate the gesture, I am somewhat embarrassed these days - as 
you say, many others deserve this more than me these days.

So please remove it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[Steve Dower]

Steve Dower  added the comment:

So it'll take a bit more rearranging to get everything to fit - I've attached 
one proposal that shuffles the thanks to Mark Hammond down below the "enable 
long path names" button. (It's grey text in the screenshot, but I've switched 
it to black already.)

Alternatively, we could drop that note completely. It's entirely possible that 
Mark feels he's been thanked enough, and is now just embarrassed that we keep 
it around :) There are certainly enough other people with significant 
contributions on Windows who also deserve thanks.

One final option would be to move the "fix long paths" button to earlier in the 
install, though I'm not doing that during RC. The reason it's not part of the 
regular install is because it always requires Admin, and while it would be 
great to have it enabled by default, we already have enough people getting 
confused about whether admin is required to install or not (it's not, but you 
have to change the default launcher option on the front page).

Anyone have any thoughts?

--
nosy: +mhammond
Added file: https://bugs.python.org/file49387/NewInstallSuccessPage.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[wyz23x2]

wyz23x2  added the comment:

+1. I observe it too.

--
nosy: +wyz23x2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[Zachary Ware]

Change by Zachary Ware :


--
assignee:  -> steve.dower
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41526] Python 3.9.0rc1 "setup successful" dialog box overflow

[Peter Lovett]

New submission from Peter Lovett :

"Setup was successful" dialog box text overflows the box, and last line can't 
be read.

--
components: Installation
files: Python 3.9.0rc1 setup successful overflow dialog box.PNG
messages: 375206
nosy: PeterL777
priority: normal
severity: normal
status: open
title: Python 3.9.0rc1 "setup successful" dialog box overflow
type: behavior
versions: Python 3.9
Added file: https://bugs.python.org/file49383/Python 3.9.0rc1 setup successful 
overflow dialog box.PNG

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com