[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Added file: https://bugs.python.org/file49458/script.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Added file: https://bugs.python.org/file49457/script.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Removed file: https://bugs.python.org/file49457/script.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Added file: https://bugs.python.org/file49455/before.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Added file: https://bugs.python.org/file49456/after.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Ethan Furman]

Change by Ethan Furman :


--
nosy: +ethan.furman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Soumendra Ganguly  added the comment:

All images, test programs, and old patches have been removed.

window resize test is now being performed using stty.

On linux:
stty -F  rows x cols y

On BSDs:
stty -f  rows x cols y

to change window size.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Removed file: https://bugs.python.org/file49393/test.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Removed file: https://bugs.python.org/file49395/pty.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Removed file: https://bugs.python.org/file49390/pty.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Removed file: https://bugs.python.org/file49391/before.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Removed file: https://bugs.python.org/file49392/after.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Removed file: https://bugs.python.org/file49396/pty.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Removed file: https://bugs.python.org/file49402/pty.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


Removed file: https://bugs.python.org/file49386/pty.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Soumendra Ganguly  added the comment:

v0.5 had introduced minor mistakes + one hack [ was using master instead of 
slave to set window size ]. v0.6 removes all such mistakes.

--
Added file: https://bugs.python.org/file49404/pty.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Soumendra Ganguly  added the comment:

Further note: login_tty will also enable us to set slave termios from the 
parent process in pty.spawn.

Due to the fact that reviewing patches can be overwhelming, v0.5 removes a lot 
of stuff and instead simply performs window resize by calling ioctl TIOCSWINSZ 
on the master end of the pty. Still works as expected.

--
Added file: https://bugs.python.org/file49402/pty.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Soumendra Ganguly  added the comment:

Further proposal: Rename my _login_tty to login_tty and make it available as a 
part of the pty library. Note that usually login_tty accompanies openpty and 
forkpty on a system; for example, see

https://www.man7.org/linux/man-pages/man3/login_tty.3.html
https://man.openbsd.org/login_tty
https://netbsd.gw.com/cgi-bin/man-cgi?login_tty++NetBSD-current

However, python's pty only offers openpty and forkpty in the form of 
pty.openpty and pty.fork respectively. While it is true that forkpty [ pty.fork 
] combines openpty, fork, and login_tty, it also closes the slave end of the 
pty, making it unsuitable for situations where the slave end needs to be kept 
open; for example, in my patch, the slave end is used to set the window size; 
or, in case someone wants to do even better and register a SIGWINCH handler for 
situations in which the window size can change.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Soumendra Ganguly  added the comment:

v0.4 puts try-except guards around imports so that existing code does not break.

--
Added file: https://bugs.python.org/file49396/pty.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Soumendra Ganguly  added the comment:

v0.3 removes _login_pty() and defines _login_tty() instead; the latter is based 
on login_tty(3) from glibc.

--
Added file: https://bugs.python.org/file49395/pty.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41541] [PATCH] Make pty.spawn set window size

[Soumendra Ganguly]

Change by Soumendra Ganguly :


--
title: Make pty.spawn set window size [ patch + before, after screenshots ] -> 
[PATCH] Make pty.spawn set window size

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com