[issue41670] ceval traces code differently with USE_COMPUTED_GOTOS

[Ammar Askar]

Change by Ammar Askar :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41670] ceval traces code differently with USE_COMPUTED_GOTOS

[Mark Shannon]

Mark Shannon  added the comment:


New changeset 17b5be0c0a3f74141014e06a660f1b5ddb002fec by Mark Shannon in 
branch 'master':
bpo-41670: Remove outdated predict macro invocation. (GH-22026)
https://github.com/python/cpython/commit/17b5be0c0a3f74141014e06a660f1b5ddb002fec


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41670] ceval traces code differently with USE_COMPUTED_GOTOS

[Mark Shannon]

Change by Mark Shannon :


--
keywords: +patch
pull_requests: +21126
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22026

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41670] ceval traces code differently with USE_COMPUTED_GOTOS

[Mark Shannon]

Mark Shannon  added the comment:

A couple of things to fix here.

Firstly, the PREDICTion of POP_BLOCK in FOR_ITER shouldn't be there. POP_BLOCK 
doesn't normally occur after a loop and hasn't since we removed "pseudo 
exceptions" from the interpreter a couple of years ago.

Secondly, there is the issue of PREDICTs skipping tracing.
Either we can make sure that no PREDICTs cross a line boundary, which seems 
error prone, or we add the check for tracing into the PREDICT macro, which 
seems more robust.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41670] ceval traces code differently with USE_COMPUTED_GOTOS

[Ammar Askar]

Change by Ammar Askar :


--
title: ceval traces code differently based with USE_COMPUTED_GOTOS -> ceval 
traces code differently with USE_COMPUTED_GOTOS

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com