[issue41729] test_winconsoleio fails and hangs on Windows

Terry J. Reedy added the comment: New changeset c2577b9e0e2f8652f079b4ac473347c63f15e25c by Miss Islington (bot) in branch '3.9': bpo-41729: Fix test_winconsole failures (3) and hang (GH-22146) https://github.com/python/cpython/commit/c2577b9e0e2f8652f079b4ac473347c63f15e25c --

[issue41729] test_winconsoleio fails and hangs on Windows

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41729] test_winconsoleio fails and hangs on Windows

miss-islington added the comment: New changeset bbab34084e876291d96a65741f075db3adfa7733 by Miss Islington (bot) in branch '3.8': bpo-41729: Fix test_winconsole failures (3) and hang (GH-22146) https://github.com/python/cpython/commit/bbab34084e876291d96a65741f075db3adfa7733 --

[issue41729] test_winconsoleio fails and hangs on Windows

Change by miss-islington : -- nosy: +miss-islington nosy_count: 6.0 -> 7.0 pull_requests: +21266 pull_request: https://github.com/python/cpython/pull/22211 ___ Python tracker

[issue41729] test_winconsoleio fails and hangs on Windows

Change by miss-islington : -- pull_requests: +21267 pull_request: https://github.com/python/cpython/pull/22212 ___ Python tracker ___

[issue41729] test_winconsoleio fails and hangs on Windows

Terry J. Reedy added the comment: New changeset 31c9828ec026e5d9b9122d55bf0aa7cb45bfecc5 by Terry Jan Reedy in branch 'master': bpo-41729: Fix test_winconsole failures (3) and hang (GH-22146) https://github.com/python/cpython/commit/31c9828ec026e5d9b9122d55bf0aa7cb45bfecc5 --

[issue41729] test_winconsoleio fails and hangs on Windows

Steve Dower added the comment: No objections. I'd guess it was a typo. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue41729] test_winconsoleio fails and hangs on Windows

Terry J. Reedy added the comment: Steve, as author of the file and line in question, do you have any objection to changing it? -- ___ Python tracker ___

[issue41729] test_winconsoleio fails and hangs on Windows

Terry J. Reedy added the comment: I was assuming that the default was 1, not 0. But now that CI tests pass code as is, I will leave it alone. -- ___ Python tracker ___

[issue41729] test_winconsoleio fails and hangs on Windows

Eryk Sun added the comment: > Is this line needed with a repeat of 1, or should it be removed? It's not documented what it means to write a key event with wRepeatCount set to 0. It happens to work, but I'd leave it set to 1, which means the key was pressed once. Ideally, there should also

[issue41729] test_winconsoleio fails and hangs on Windows

Change by Terry J. Reedy : -- keywords: +patch pull_requests: +21228 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/22146 ___ Python tracker

[issue41729] test_winconsoleio fails and hangs on Windows

Terry J. Reedy added the comment: After splitting the two reads onto two lines, the indefinite hang happens in the second one, stdin.readall. def test_ctrl_z(self): with open('CONIN$', 'rb', buffering=0) as stdin: source = '\xC4\x1A\r\n'.encode('utf-16-le')

[issue41729] test_winconsoleio fails and hangs on Windows

Eryk Sun added the comment: > ÄÄ^Z^Z^Z^Z^Z^Z^Z^Z^Z^Z I don't know why Steve made write_input (PC/_testconsole.c) set wRepeatCount in each KeyEvent record to 10. Maybe it was a typo. Previous console implementations have ignored the repeat count, so it wasn't an issue. test_ctrl_z

[issue41729] test_winconsoleio fails and hangs on Windows

Terry J. Reedy added the comment: Running test -v test_winconsoleio showed that the hang is in test_cntl_z. With that commented out, I get failures in test_input (1st assert) and test_partial_reads and some bizarre console behavior. F:\dev\3x>python -m test -v test_winconsoleio Running

[issue41729] test_winconsoleio fails and hangs on Windows

New submission from Terry J. Reedy : f:\dev\3x>python -m test test.test_winconsoleio Running Debug|Win32 interpreter... 0:00:00 Run tests sequentially 0:00:00 [1/1] test.test_winconsoleio ÄÄ^Z^Z^Z^Z^Z^Z^Z^Z^Z^Z It quickly fails, prints seems garbage and several blanks lines,