[issue41735] Thread locks in zlib module may go wrong in rare case

Ma Lin added the comment: Thanks for review! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41735] Thread locks in zlib module may go wrong in rare case

miss-islington added the comment: New changeset 57100c86baa8451a568348646834380cd425b858 by Miss Islington (bot) in branch '3.10': [3.10] bpo-41735: Fix thread lock in zlib.Decompress.flush() may go wrong (GH-29587) (GH-29811)

[issue41735] Thread locks in zlib module may go wrong in rare case

Gregory P. Smith added the comment: Thanks malin! -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker ___

[issue41735] Thread locks in zlib module may go wrong in rare case

Change by miss-islington : -- pull_requests: +28044 pull_request: https://github.com/python/cpython/pull/29812 ___ Python tracker ___

[issue41735] Thread locks in zlib module may go wrong in rare case

Gregory P. Smith added the comment: New changeset 86c1265cdc64030c8921e0da5fcae2ac64299c26 by Ma Lin in branch '3.9': [3.9] bpo-41735: Fix thread lock in zlib.Decompress.flush() may go wrong (GH-29588) https://github.com/python/cpython/commit/86c1265cdc64030c8921e0da5fcae2ac64299c26

[issue41735] Thread locks in zlib module may go wrong in rare case

Gregory P. Smith added the comment: New changeset 7edb6270a78c695e4c2ae2432797dc18105374fc by Ma Lin in branch 'main': bpo-41735: Fix thread lock in zlib.Decompress.flush() may go wrong (GH-29587) https://github.com/python/cpython/commit/7edb6270a78c695e4c2ae2432797dc18105374fc --

[issue41735] Thread locks in zlib module may go wrong in rare case

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +28043 pull_request: https://github.com/python/cpython/pull/29811 ___ Python tracker

[issue41735] Thread locks in zlib module may go wrong in rare case

Change by Gregory P. Smith : -- assignee: -> gregory.p.smith resolution: later -> stage: resolved -> patch review ___ Python tracker ___

[issue41735] Thread locks in zlib module may go wrong in rare case

Ma Lin added the comment: Sorry, I found an omission. The previous PRs fixed the bug in these methods: zlib.Compress.compress() zlib.Decompress.decompress() This method also has this bug, fix in PR29587 (main/3.10) and PR29588 (3.9-): zlib.Decompress.flush() Attached file

[issue41735] Thread locks in zlib module may go wrong in rare case

Change by Ma Lin : -- pull_requests: +27831 pull_request: https://github.com/python/cpython/pull/29588 ___ Python tracker ___ ___

[issue41735] Thread locks in zlib module may go wrong in rare case

Change by Ma Lin : -- pull_requests: +27830 pull_request: https://github.com/python/cpython/pull/29587 ___ Python tracker ___ ___

[issue41735] Thread locks in zlib module may go wrong in rare case

Ma Lin added the comment: Thanks for review. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41735] Thread locks in zlib module may go wrong in rare case

Łukasz Langa added the comment: Thanks! ✨  ✨ -- nosy: +lukasz.langa resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41735] Thread locks in zlib module may go wrong in rare case

Change by Ma Lin : -- pull_requests: +21213 pull_request: https://github.com/python/cpython/pull/22132 ___ Python tracker ___ ___

[issue41735] Thread locks in zlib module may go wrong in rare case

Change by Ma Lin : -- pull_requests: +21211 pull_request: https://github.com/python/cpython/pull/22130 ___ Python tracker ___ ___

[issue41735] Thread locks in zlib module may go wrong in rare case

Change by Ma Lin : -- keywords: +patch pull_requests: +21208 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22126 ___ Python tracker ___

[issue41735] Thread locks in zlib module may go wrong in rare case

New submission from Ma Lin : The code in zlib module: self->zst.next_in = data->buf; // set next_in ... ENTER_ZLIB(self); // acquire thread lock `self->zst` is a `z_stream` struct defined in zlib, used to record states of a compress/decompress stream: typedef struct