[issue41818] Lib/pty.py major revision

Change by Soumendra Ganguly : -- pull_requests: +27900 pull_request: https://github.com/python/cpython/pull/29658 ___ Python tracker ___ ___

[issue41818] Lib/pty.py major revision

Gregory P. Smith added the comment: New changeset 245f1f260577a005fd631144b4377febef0b47ed by Gregory P. Smith in branch 'main': bpo-41818: ++ termios versionadded markers. (GH-27987) https://github.com/python/cpython/commit/245f1f260577a005fd631144b4377febef0b47ed -- _

[issue41818] Lib/pty.py major revision

Change by Gregory P. Smith : -- pull_requests: +26434 pull_request: https://github.com/python/cpython/pull/27987 ___ Python tracker ___

[issue41818] Lib/pty.py major revision

Gregory P. Smith added the comment: New changeset ae224bb566301d3602e9b090e37c1dcf5a48c914 by Soumendra Ganguly in branch 'main': bpo-41818: Add termios.tcgetwinsize(), termios.tcsetwinsize(). (GH-23686) https://github.com/python/cpython/commit/ae224bb566301d3602e9b090e37c1dcf5a48c914 -

[issue41818] Lib/pty.py major revision

Petr Viktorin added the comment: New changeset 65cf1ad6723b6b4489fa7dda04283bb2466be531 by Petr Viktorin in branch 'master': bpo-41818: Close file descriptors in test_openpty (#GH-24119) https://github.com/python/cpython/commit/65cf1ad6723b6b4489fa7dda04283bb2466be531 -- __

[issue41818] Lib/pty.py major revision

Soumendra Ganguly added the comment: Thank you for the fix. That test was created by modifying an existing test which already had that issue; it is documented in a comment by user nnorwitz in the file. If your solution resolves the problem for all the tests in "class PtyTest", then can you p

[issue41818] Lib/pty.py major revision

Petr Viktorin added the comment: I noticed an issue in one of the newly added tests; see GH-24119 -- ___ Python tracker ___ ___ Pyt

[issue41818] Lib/pty.py major revision

Change by Petr Viktorin : -- nosy: +petr.viktorin nosy_count: 11.0 -> 12.0 pull_requests: +22949 pull_request: https://github.com/python/cpython/pull/24119 ___ Python tracker _

[issue41818] Lib/pty.py major revision

Change by Soumendra Ganguly : -- pull_requests: +22598 pull_request: https://github.com/python/cpython/pull/23740 ___ Python tracker ___ ___

[issue41818] Lib/pty.py major revision

Change by Soumendra Ganguly : -- pull_requests: +22550 pull_request: https://github.com/python/cpython/pull/23686 ___ Python tracker ___ ___

[issue41818] Lib/pty.py major revision

Change by Soumendra Ganguly : -- pull_requests: +22425 pull_request: https://github.com/python/cpython/pull/23546 ___ Python tracker ___ ___

[issue41818] Lib/pty.py major revision

Andrew Svetlov added the comment: New changeset 74311aeb45b52cc145d27d9fca99f01874d6882d by Soumendra Ganguly in branch 'master': bpo-41818: Fix test_master_read() so that it succeeds on all platforms that either raise OSError or return b"" upon reading from master (GH-23536) https://github.

[issue41818] Lib/pty.py major revision

Soumendra Ganguly added the comment: Update: I closed PR 23533. PR 23536 is much better. It will help us detect exact behavior on each platform, which is necessary for making pty.spawn() successfully exit its copy loop. -- ___ Python tracker

[issue41818] Lib/pty.py major revision

Change by Soumendra Ganguly : -- pull_requests: +22418 pull_request: https://github.com/python/cpython/pull/23536 ___ Python tracker ___ ___

[issue41818] Lib/pty.py major revision

Soumendra Ganguly added the comment: PR-23533 should fix the test_master_read() issue on Solaris. Actually, instead of adding 'or PLATFORM == "SunOS"', I ended up removing the whole line and replaced it with 'if platform.system() != "Linux"' because I expect that test to fail on every platfo

[issue41818] Lib/pty.py major revision

Change by Soumendra Ganguly : -- pull_requests: +22415 pull_request: https://github.com/python/cpython/pull/23533 ___ Python tracker ___ ___

[issue41818] Lib/pty.py major revision

Soumendra Ganguly added the comment: This is actually good news. I had not tested the code on Solaris; this confirms my suspicion that Linux is the only platform that "behaves differently". Sadly, the current Lib/pty.py code depends on such "different behavior" to exit from pty.spawn()'s cop

[issue41818] Lib/pty.py major revision

Andrew Svetlov added the comment: New changeset f5a19ead4ba8c81cc27d5a530f830f4709ce240e by Soumendra Ganguly in branch 'master': bpo-41818: Make test_openpty() avoid unexpected success due to number of rows and/or number of columns being == 0. (GH-23526) https://github.com/python/cpython/co

[issue41818] Lib/pty.py major revision

Jakub Kulik added the comment: This change also broke Solaris (SunOS), where (similarly to BSDs and Darwin) OSError is not raised in the `new test_master_read()` test. Adding `or PLATFORM == "SunOS"` into the `expectedFailureOnBSD` function fixes this issue, but it's no longer just BSDs and

[issue41818] Lib/pty.py major revision

Change by Soumendra Ganguly : -- pull_requests: +22408 pull_request: https://github.com/python/cpython/pull/23526 ___ Python tracker ___ ___

[issue41818] Lib/pty.py major revision

Soumendra Ganguly added the comment: The reproducer was helpful. https://github.com/python/cpython/pull/23526 should fix this issue. -- ___ Python tracker ___ ___

[issue41818] Lib/pty.py major revision

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue41818] Lib/pty.py major revision

Zachary Ware added the comment: Moving my notes from PR23514 to here, the issue that that PR addressed is not Gentoo-specific; here's a simple reproducer on Ubuntu: ./python -c "import pty;pty.spawn('./python -m test -v test_pty'.split())" -- ___

[issue41818] Lib/pty.py major revision

Andrew Svetlov added the comment: New changeset 87f7ab5359bc12eeb858272b7bd58e132cb9c176 by Andrew Svetlov in branch 'master': bpo-41818: test_openpty succeed on Gentoo, don't expect to fail on this platform (GH-23514) https://github.com/python/cpython/commit/87f7ab5359bc12eeb858272b7bd58e13

[issue41818] Lib/pty.py major revision

STINNER Victor added the comment: > In addition to the above, if a major revision is made to pty, I'd suggest > also addressing the issue of "master/slave" terminology In bpo-34605, I chose to leave the pty module unchange since it *seems* like "master_fd" and "slave_fd" is part of the API.

[issue41818] Lib/pty.py major revision

STINNER Victor added the comment: > https://github.com/python/cpython/pull/23514 has the fix, waiting for all > buildbots finish before pressing "Merge" button. Thanks for working on a fix :-) -- ___ Python tracker

[issue41818] Lib/pty.py major revision

Andrew Svetlov added the comment: https://github.com/python/cpython/pull/23514 has the fix, waiting for all buildbots finish before pressing "Merge" button. Gentoo bots are green. -- ___ Python tracker

[issue41818] Lib/pty.py major revision

STINNER Victor added the comment: This change broke x86 Gentoo buildbots: bpo-42463. -- nosy: +vstinner ___ Python tracker ___ ___

[issue41818] Lib/pty.py major revision

Change by Andrew Svetlov : -- pull_requests: +22401 pull_request: https://github.com/python/cpython/pull/23514 ___ Python tracker ___ __

[issue41818] Lib/pty.py major revision

Andrew Svetlov added the comment: New changeset c13d89955d9a2942c6355d6839d7096323244136 by Soumendra Ganguly in branch 'master': bpo-41818: Updated tests for the standard pty library (GH-22962) https://github.com/python/cpython/commit/c13d89955d9a2942c6355d6839d7096323244136 -- nos

[issue41818] Lib/pty.py major revision

Change by Soumendra Ganguly : -- keywords: +patch pull_requests: +21878 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22962 ___ Python tracker __

[issue41818] Lib/pty.py major revision

Soumendra Ganguly added the comment: Makes sense. I will happily make a change of terminology in the pypty2 repository after the most desirable alternative is determined based on the choice of the majority. I think 'mother/son' sounds cute while still retaining the same initials as before; p

[issue41818] Lib/pty.py major revision

Kyle Stanley added the comment: In addition to the above, if a major revision is made to pty, I'd suggest also addressing the issue of "master/slave" terminology, and replace it with something comparable like "parent/child". There's an open devguide issue (https://github.com/python/devguide/

[issue41818] Lib/pty.py major revision

New submission from Soumendra Ganguly : The current pty library has the following issues: 1. Does not set slave termios. Documented in the source. 2. Does not set initial slave window size. Documented in the source. Does not handle SIGWINCH. See bpo-41494, bpo-41541. This is essential in