[issue41845] Promote PyObject_GenericGetDict to the stable API

[Steve Dower]

Steve Dower  added the comment:

Thanks!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41845] Promote PyObject_GenericGetDict to the stable API

[Steve Dower]

Steve Dower  added the comment:


New changeset 1438c2ac773e87d1f9c97fc22f2346e16bf48773 by Zackery Spytz in 
branch 'master':
bpo-41845: Move PyObject_GenericGetDict() back into the limited API (GH22646)
https://github.com/python/cpython/commit/1438c2ac773e87d1f9c97fc22f2346e16bf48773


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41845] Promote PyObject_GenericGetDict to the stable API

[Steve Dower]

Steve Dower  added the comment:

Unfortunately, fixing this won't make the builds work in previous versions, so 
it can't be backported.

We also need to update the version check in the PR - I left a comment for it.

--
nosy: +steve.dower
versions:  -Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41845] Promote PyObject_GenericGetDict to the stable API

[Zackery Spytz]

Zackery Spytz  added the comment:

I have created PR 22646 to fix this issue.  Please consider taking a look.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41845] Promote PyObject_GenericGetDict to the stable API

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
nosy: +ZackerySpytz
nosy_count: 4.0 -> 5.0
pull_requests: +21619
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22646

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41845] Promote PyObject_GenericGetDict to the stable API

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

It was moved into the "#ifndef Py_LIMITED_API" block and therefore was 
effectively excluded from the limited API.

We should fix this error in all maintained versions.

--
versions: +Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41845] Promote PyObject_GenericGetDict to the stable API

[Mark Shannon]

Mark Shannon  added the comment:

It wasn't removed in 7d95e4072169911b228c9e42367afb5f17fd3db0,
just moved from object.h to dictobject.h
It was still part of the API at that point, I think.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41845] Promote PyObject_GenericGetDict to the stable API

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

It was moved out from the limited API in issue13903 
(7d95e4072169911b228c9e42367afb5f17fd3db0). I think it was error.

--
nosy: +Mark.Shannon, serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41845] Promote PyObject_GenericGetDict to the stable API

[Alex Gaynor]

New submission from Alex Gaynor :

Currently PyObject_GenericSetDict is part of the stable API, but 
PyObject_GenericGetDict is not. I noticed this while working on 
https://github.com/PyO3/pyo3/pull/1207

Because of the symmetry here, it seems appropriate to promote Get.

--
components: C API
messages: 377388
nosy: alex, benjamin.peterson
priority: normal
severity: normal
status: open
title: Promote PyObject_GenericGetDict to the stable API
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com