[issue41971] multiple tests in test_tools fail since Python 3.9

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 4af672921949b8a10340d5e29b456091060cedeb by Miss Skeleton (bot) 
in branch '3.9':
bpo-41971: Fix test failure in test.test_tools.test_c_analyzer when mutating 
global state (GH-22652) (GH-22653)
https://github.com/python/cpython/commit/4af672921949b8a10340d5e29b456091060cedeb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41971] multiple tests in test_tools fail since Python 3.9

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
nosy:  -miss-islington
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41971] multiple tests in test_tools fail since Python 3.9

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 47ecfd8030c391779dd9d3b4b07e6b01a8392481 by Pablo Galindo in 
branch 'master':
bpo-41971: Fix test failure in test.test_tools.test_c_analyzer when mutating 
global state (GH-22652)
https://github.com/python/cpython/commit/47ecfd8030c391779dd9d3b4b07e6b01a8392481


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41971] multiple tests in test_tools fail since Python 3.9

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 6.0 -> 7.0
pull_requests: +21626
pull_request: https://github.com/python/cpython/pull/22653

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41971] multiple tests in test_tools fail since Python 3.9

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +21625
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22652

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41971] multiple tests in test_tools fail since Python 3.9

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Seems that the problem is that this check:

https://github.com/python/cpython/blob/master/Tools/c-analyzer/c_analyzer/common/files.py#L90

is done using a default value for "get_files":

https://github.com/python/cpython/blob/master/Tools/c-analyzer/c_analyzer/common/files.py#L63

But the import from source creates a new function for os.walk and therefore the 
comparison fails.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41971] multiple tests in test_tools fail since Python 3.9

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Adding Eric Snow as this seems to be something going on on the c_analyzer

--
nosy: +eric.snow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41971] multiple tests in test_tools fail since Python 3.9

[Chih-Hsuan Yen]

Chih-Hsuan Yen  added the comment:

Looks like those failures in test_tools happen only when test_check_c_globals 
is imported and a test in test_imp is run.

```
$ cat matchfile
test.test_tools.*
test.test_imp.ImportTests.test_load_from_source

$ ./python -m test --matchfile matchfile test_check_c_globals test_imp 
test_tools
0:00:00 load avg: 0.90 Run tests sequentially
0:00:00 load avg: 0.90 [1/3] test_check_c_globals
0:00:00 load avg: 0.90 [2/3] test_imp -- test_check_c_globals run no tests
0:00:00 load avg: 0.90 [3/3] test_tools
test test_tools failed -- multiple errors occurred; run in verbose mode for 
details
test_tools failed

== Tests result: FAILURE ==

1 test OK.

1 test failed:
test_tools

1 test run no tests:
test_check_c_globals

Total duration: 1.9 sec
Tests result: FAILURE
```

If I remove test_check_c_globals from the second command or 
test.test_imp.ImportTests.test_load_from_source from matchfile, test_tools does 
not fail.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41971] multiple tests in test_tools fail since Python 3.9

[Chih-Hsuan Yen]

Change by Chih-Hsuan Yen :


--
nosy: +yan12125

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41971] multiple tests in test_tools fail since Python 3.9

[Dong-hee Na]

Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41971] multiple tests in test_tools fail since Python 3.9

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41971] multiple tests in test_tools fail since Python 3.9

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

All our buildbots are running these test without any problem and I cannot 
reproduce this locally after a fresh install from the binaries in 3.9, so my 
guess is that there must be something going on on your end.

❯ ./installed_dir/bin/python3 -m test test_tools
0:00:00 load avg: 6.90 Run tests sequentially
0:00:00 load avg: 6.90 [1/1] test_tools

== Tests result: SUCCESS ==

1 test OK.

Total duration: 40 ms
Tests result: SUCCESS

~/Downloads/Python-3.9.0
❯ ./python -m test test_tools
0:00:00 load avg: 6.43 Run tests sequentially
0:00:00 load avg: 6.43 [1/1] test_tools

== Tests result: SUCCESS ==

1 test OK.

Total duration: 2.5 sec
Tests result: SUCCESS

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41971] multiple tests in test_tools fail since Python 3.9

[Felix Yan]

New submission from Felix Yan :

I am packaging Python for Arch and the test suite of Python 3.8.6 passes here 
without these:

==
FAIL: test_multiple_roots 
(test.test_tools.test_c_analyzer.test_common.test_files.IterFilesTests)
--
Traceback (most recent call last):
  File 
"/build/python/src/Python-3.9.0/Lib/test/test_tools/test_c_analyzer/test_common/test_files.py",
 line 118, in test_multiple_roots
self.assertEqual(self.calls, [
AssertionError: Lists differ: [('_w[26 chars]tion walk at 0x7ff2eb562f70>)), 
('_walk', ('eg[42 chars]0>))] != [('_w[26 chars]tion _walk_tree at 
0x7ff2e5babdc0>)), ('_walk'[54 chars]0>))]

First differing element 0:
('_walk', ('spam', '.c', ))
('_walk', ('spam', '.c', ))

- [('_walk', ('spam', '.c', )),
? ^

+ [('_walk', ('spam', '.c', )),
? ++   + 

-  ('_walk', ('eggs', '.c', ))]
? ^

+  ('_walk', ('eggs', '.c', ))]
? ++   + 


==
FAIL: test_multiple_suffixes 
(test.test_tools.test_c_analyzer.test_common.test_files.IterFilesTests)
--
Traceback (most recent call last):
  File 
"/build/python/src/Python-3.9.0/Lib/test/test_tools/test_c_analyzer/test_common/test_files.py",
 line 189, in test_multiple_suffixes
self.assertEqual(self.calls, [
AssertionError: Lists differ: [('_walk', ('spam', None, ))] != [('_walk', ('spam', None, ))]

First differing element 0:
('_walk', ('spam', None, ))
('_walk', ('spam', None, ))

- [('_walk', ('spam', None, ))]
? ^

+ [('_walk', ('spam', None, ))]
? ++   + 


==
FAIL: test_no_suffix 
(test.test_tools.test_c_analyzer.test_common.test_files.IterFilesTests) [None]
--
Traceback (most recent call last):
  File 
"/build/python/src/Python-3.9.0/Lib/test/test_tools/test_c_analyzer/test_common/test_files.py",
 line 209, in test_no_suffix
self.assertEqual(self.calls, [
AssertionError: Lists differ: [('_walk', ('spam', None, ))] != [('_walk', ('spam', None, ))]

First differing element 0:
('_walk', ('spam', None, ))
('_walk', ('spam', None, ))

- [('_walk', ('spam', None, ))]
? ^

+ [('_walk', ('spam', None, ))]
? ++   + 


==
FAIL: test_no_suffix 
(test.test_tools.test_c_analyzer.test_common.test_files.IterFilesTests) []
--
Traceback (most recent call last):
  File 
"/build/python/src/Python-3.9.0/Lib/test/test_tools/test_c_analyzer/test_common/test_files.py",
 line 209, in test_no_suffix
self.assertEqual(self.calls, [
AssertionError: Lists differ: [('_walk', ('spam', '', ))] != [('_walk', ('spam', '', ))]

First differing element 0:
('_walk', ('spam', '', ))
('_walk', ('spam', '', ))

- [('_walk', ('spam', '', ))]
?   ^

+ [('_walk', ('spam', '', ))]
?   ++   + 


==
FAIL: test_no_suffix 
(test.test_tools.test_c_analyzer.test_common.test_files.IterFilesTests) [()]
--
Traceback (most recent call last):
  File 
"/build/python/src/Python-3.9.0/Lib/test/test_tools/test_c_analyzer/test_common/test_files.py",
 line 209, in test_no_suffix
self.assertEqual(self.calls, [
AssertionError: Lists differ: [('_walk', ('spam', (), ))] != [('_walk', ('spam', (), ))]

First differing element 0:
('_walk', ('spam', (), ))
('_walk', ('spam', (), ))

- [('_walk', ('spam', (), ))]
?   ^

+ [('_walk', ('spam', (), ))]
?   ++   + 


==
FAIL: test_one_root 
(test.test_tools.test_c_analyzer.test_common.test_files.IterFilesTests)
--
Traceback (most recent call last):
  File 
"/build/python/src/Python-3.9.0/Lib/test/test_tools/test_c_analyzer/test_common/test_files.py",
 line 99, in test_one_root
self.assertEqual(self.calls, [
AssertionError: Lists differ: [('_walk', ('spam', '.c', ))] != [('_walk', ('spam', '.c