[issue42146] subprocess.Popen() leaks cwd in case of uid/gid overflow

Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker ___

[issue42146] subprocess.Popen() leaks cwd in case of uid/gid overflow

Gregory P. Smith added the comment: New changeset d3b4e068077dd26927ae7485bd0303e09d962c02 by Alexey Izbyshev in branch 'master': bpo-42146: Unify cleanup in subprocess_fork_exec() (GH-22970) https://github.com/python/cpython/commit/d3b4e068077dd26927ae7485bd0303e09d962c02 --

[issue42146] subprocess.Popen() leaks cwd in case of uid/gid overflow

Alexey Izbyshev added the comment: Thanks for merging! I've rebased PR 22970. -- ___ Python tracker ___ ___ Python-bugs-list

[issue42146] subprocess.Popen() leaks cwd in case of uid/gid overflow

miss-islington added the comment: New changeset c12afa92b0db6f017e479b41f95d75bac7b59850 by Miss Skeleton (bot) in branch '3.9': [3.9] bpo-42146: Fix memory leak in subprocess.Popen() in case of uid/gid overflow (GH-22966) (GH-22980)

[issue42146] subprocess.Popen() leaks cwd in case of uid/gid overflow

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +21897 pull_request: https://github.com/python/cpython/pull/22980 ___ Python tracker

[issue42146] subprocess.Popen() leaks cwd in case of uid/gid overflow

Gregory P. Smith added the comment: New changeset c0590c0033e86f98cdf5f2ca6898656f98ab4053 by Alexey Izbyshev in branch 'master': bpo-42146: Fix memory leak in subprocess.Popen() in case of uid/gid overflow (GH-22966)

[issue42146] subprocess.Popen() leaks cwd in case of uid/gid overflow

Change by Alexey Izbyshev : -- type: behavior -> resource usage ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue42146] subprocess.Popen() leaks cwd in case of uid/gid overflow

Change by Alexey Izbyshev : -- keywords: +patch stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue42146] subprocess.Popen() leaks cwd in case of uid/gid overflow

Alexey Izbyshev added the comment: I've submitted both PRs. Regarding PR 22970: * I made it a draft since we'd probably want to fix the leak first, but then it will have to be rebased. * It fixes a bug with _enable_gc(): if it failed after fork(), we'd raise OSError instead.

[issue42146] subprocess.Popen() leaks cwd in case of uid/gid overflow

Change by Alexey Izbyshev : -- pull_requests: +21885 pull_request: https://github.com/python/cpython/pull/22970 ___ Python tracker ___

[issue42146] subprocess.Popen() leaks cwd in case of uid/gid overflow

Change by Alexey Izbyshev : -- keywords: +patch pull_requests: +21882 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22966 ___ Python tracker ___

[issue42146] subprocess.Popen() leaks cwd in case of uid/gid overflow

New submission from Alexey Izbyshev : The following test demonstrates the leak: ``` import subprocess cwd = 'x' * 10**6 for __ in range(100): try: subprocess.call(['/xxx'], cwd=cwd, user=2**64) except OverflowError: pass from resource import *