[issue42470] DeprecationWarning triggers for sequences which happen to be sets as well

Raymond Hettinger added the comment: Given that this is rare and that it is a behavior change, I'm only applying this to 3.10. If you think it is essential for 3.9, feel free to reopen and we'll discuss it with the release manager. -- components: +Library (Lib) resolution: -> fixed

[issue42470] DeprecationWarning triggers for sequences which happen to be sets as well

Raymond Hettinger added the comment: New changeset 1e27b57dbc8c1b758e37a531487813aef2d111ca by masklinn in branch 'master': bpo-42470: Do not warn on sequences which are also sets in random.sample() (GH-23665) https://github.com/python/cpython/commit/1e27b57dbc8c1b758e37a531487813aef2d111ca

[issue42470] DeprecationWarning triggers for sequences which happen to be sets as well

Xavier Morel added the comment: Tried patterning the PR after the one which originally added the warning. Wasn't too sure how the news item was supposed to be generated, and grepping the repository didn't reveal any clear script doing that, so I made up a date and copied an existing random b

[issue42470] DeprecationWarning triggers for sequences which happen to be sets as well

Change by Xavier Morel : -- pull_requests: +22532 pull_request: https://github.com/python/cpython/pull/23665 ___ Python tracker ___

[issue42470] DeprecationWarning triggers for sequences which happen to be sets as well

Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 4.0 -> 5.0 pull_requests: +22507 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23639 ___ Python tracker _

[issue42470] DeprecationWarning triggers for sequences which happen to be sets as well

Serhiy Storchaka added the comment: Open it against master. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list

[issue42470] DeprecationWarning triggers for sequences which happen to be sets as well

Xavier Morel added the comment: I was preparing to open the PR but now I'm doubting: should I open the PR against master and miss islington will backport it, or should I open the PR against 3.9? -- ___ Python tracker

[issue42470] DeprecationWarning triggers for sequences which happen to be sets as well

Raymond Hettinger added the comment: >>> Do you want to submit a PR for this? > > Sure. Do you think the code I proposed would be suitable? Yes. It will need tests and a news entry as well. -- assignee: -> rhettinger ___ Python tracker

[issue42470] DeprecationWarning triggers for sequences which happen to be sets as well

Xavier Morel added the comment: > Do you want to submit a PR for this? Sure. Do you think the code I proposed would be suitable? > * The current logic matches the logic before the warning was added. > * The proposed logic matches what the code will do after the > deprecation period (it will

[issue42470] DeprecationWarning triggers for sequences which happen to be sets as well

Raymond Hettinger added the comment: +0 Do you want to submit a PR for this? Some thoughts: * The current logic matches the logic before the warning was added. * The proposed logic matches what the code will do after the deprecation period (it will only check for non-sequences). * There i

[issue42470] DeprecationWarning triggers for sequences which happen to be sets as well

Change by Karthikeyan Singaravelan : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue42470] DeprecationWarning triggers for sequences which happen to be sets as well

New submission from Xavier Morel : In 3.9, using `random.sample` on sets triggers DeprecationWarning: Sampling from a set deprecated since Python 3.9 and will be removed in a subsequent version. *However* it also triggers on types which implement *both* Sequence and Set, despite Sequence