[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

Petr Viktorin added the comment: I usually wait until buildbots are green before closing the bpo, but I don't think there's anything else. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

Pablo Galindo Salgado added the comment: Is there anything left in this issue? -- nosy: +pablogsal ___ Python tracker ___ ___

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

Petr Viktorin added the comment: New changeset 632e8a69593efb12ec58d90e624ddf249a7a1b65 by Miss Islington (bot) in branch '3.10': bpo-42747: Remove Py_TPFLAGS_HAVE_AM_SEND and make Py_TPFLAGS_HAVE_VERSION_TAG no-op (GH-27260) (GH-27306)

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

miss-islington added the comment: New changeset a4760cc32d9e5dac7be262e9736eb30502cd7be3 by Petr Viktorin in branch 'main': bpo-42747: Remove Py_TPFLAGS_HAVE_AM_SEND and make Py_TPFLAGS_HAVE_VERSION_TAG no-op (GH-27260)

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

Change by miss-islington : -- pull_requests: +25850 pull_request: https://github.com/python/cpython/pull/27306 ___ Python tracker ___

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

Change by Petr Viktorin : -- keywords: +patch pull_requests: +25805 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27260 ___ Python tracker ___

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

Petr Viktorin added the comment: The bit cannot be repurposed, since older extensions using the stable ABI might set it. It doesn't make much sense to remove the Py_TPFLAGS_HAVE_VERSION_TAG or Py_TPFLAGS_HAVE_FINALIZE defines; I'd let them stay to document that the bits are reserved.

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

Petr Viktorin added the comment: > I'm only aware of PyQt which uses the stable ABI. Is there other projects > using it? Do these projects check for Py_TPFLAGS_HAVE_VERSION_TAG or > Py_TPFLAGS_HAVE_FINALIZE flag? I think there are. Who knows how many; they're not required to register

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

STINNER Victor added the comment: Ah, I see that there is a misunderstanding. The flag is used for two things: (*) Create/Declare a type IMO Py_TPFLAGS_HAVE_VERSION_TAG and Py_TPFLAGS_HAVE_FINALIZE are useless for that. (*) Check if a type has the flag An extension built with the stable

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

STINNER Victor added the comment: Serhiy Storchaka: > I don't think that it was right thing to break binary compatibility. It > virtually buried the stable ABI. IMO there is a misunderstanding about the stable ABI. PyType_FromSpec() doesn't need Py_TPFLAGS_HAVE_xxx flags: this function

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

Serhiy Storchaka added the comment: I don't think that it was right thing to break binary compatibility. It virtually buried the stable ABI. -- nosy: +serhiy.storchaka ___ Python tracker

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

Petr Viktorin added the comment: IMO, these flags are useless. Both the stable ABI and the version-specific builds of extension modules use the memory layout of the current interpreter and fill unset slots with NULL. Py_TPFLAGS_HAVE_AM_SEND is new in 3.10, so it can be removed (or replaced

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

hai shi added the comment: >I don't see the purpose of the Py_TPFLAGS_HAVE_VERSION_TAG flag. IMO, There have no more exact description of `Py_TPFLAGS_HAVE_VERSION_TAG`in docs, so I perfer to remove it. > By the way, is it worth it to remove Py_TPFLAGS_HAVE_FINALIZE? Or is it going > to

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

STINNER Victor added the comment: Maybe we can keep the constants but define them as 0 and deprecate them. The question is more if these constants solve a real ABI issue or not. -- ___ Python tracker

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

Dong-hee Na added the comment: Let's emit the deprecated message if Py_TPFLAGS_HAVE_VERSION_TAG is set ;) For example, PyType_Ready looks like a good place -- nosy: +corona10 ___ Python tracker

[issue42747] Remove Py_TPFLAGS_HAVE_VERSION_TAG flag?

New submission from STINNER Victor : Since the PyTypeObject structure is excluded from the limited C API and the stable ABI on purpose (PEP 384), I don't see the purpose of the Py_TPFLAGS_HAVE_VERSION_TAG flag. Moreover, a new flag was added recently: #if !defined(Py_LIMITED_API) ||