[issue42778] Add follow_symlinks=True parameter to both os.path.samefile() and Path.samefile()

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42778] Add follow_symlinks=True parameter to both os.path.samefile() and Path.samefile()

[Andrei Kulakov]

Andrei Kulakov  added the comment:

Looks like this issue can be closed.

--
nosy: +andrei.avk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42778] Add follow_symlinks=True parameter to both os.path.samefile() and Path.samefile()

[Ross Rhodes]

Ross Rhodes  added the comment:

Thanks for sharing the alternative approach, Serhiy. Sounds like the proposed 
changes aren’t necessary if the combined use of samestat and lstat achieve the 
desired behaviour.

Any objections if I close the open PR?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42778] Add follow_symlinks=True parameter to both os.path.samefile() and Path.samefile()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Why is this feature needed? Currently you can use a combination of samestat() 
with lstat(). And more, you can follow symbolic links only for one of arguments.

samestat(stat(path1), stat(path1))  # same as samefile(path1, path1)
samestat(lstat(path1), stat(path1))
samestat(stat(path1), lstat(path1))
samestat(lstat(path1), lstat(path1))

samefile() covers one (presumably most common) of these cases. The proposed 
option would cover yet one (is it common enough?). And there are two mixed 
cases remained.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42778] Add follow_symlinks=True parameter to both os.path.samefile() and Path.samefile()

[Ross Rhodes]

Ross Rhodes  added the comment:

Hi Tom,

Thanks for raising this issue. I've opened a PR to permit us to set 
`follow_symlinks` in both os.path and pathlib. Feel free to leave feedback.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42778] Add follow_symlinks=True parameter to both os.path.samefile() and Path.samefile()

[Ross Rhodes]

Change by Ross Rhodes :


--
keywords: +patch
nosy: +trrhodes
nosy_count: 1.0 -> 2.0
pull_requests: +22839
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23996

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42778] Add follow_symlinks=True parameter to both os.path.samefile() and Path.samefile()

[Tom Hale]

Tom Hale  added the comment:

In summary:

The underlying os.stat() takes a follow_symlinks=True parameter but it can't be 
set to False when trying to samefile() two symbolic links.

--
title: Add follow_symlinks=True to {os.path,Path}.samefile -> Add 
follow_symlinks=True parameter to both os.path.samefile() and Path.samefile()

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com