[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by STINNER Victor : -- Removed message: https://bugs.python.org/msg394832 ___ Python tracker ___ ___ Python-bugs-list

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

miss-islington added the comment: New changeset e30fe27dabbc6b48736c3c17d57f6fa542376e8f by Miss Islington (bot) in branch '3.10': bpo-42972: _thread.RLock implements the GH protocol (GH-26734) https://github.com/python/cpython/commit/e30fe27dabbc6b48736c3c17d57f6fa542376e8f --

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset 1cd3d859a49b047dd08abb6f44f0539564d3525a by Victor Stinner in branch 'main': bpo-42972: _thread.RLock implements the GH protocol (GH-26734) https://github.com/python/cpython/commit/1cd3d859a49b047dd08abb6f44f0539564d3525a --

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +25322 pull_request: https://github.com/python/cpython/pull/26735 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by STINNER Victor : -- pull_requests: +25321 pull_request: https://github.com/python/cpython/pull/26734 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Pablo Galindo Salgado : -- priority: release blocker -> ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset 84d80f5f30b1f545083c70a7d4e1e79ab75f9fa6 by Erlend Egeberg Aasland in branch '3.10': [3.10] bpo-42972: Track sqlite3 statement objects (GH-26475) (GH-26515) https://github.com/python/cpython/commit/84d80f5f30b1f545083c70a7d4e1e79ab75f9fa6

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +25110 pull_request: https://github.com/python/cpython/pull/26515 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset fffa0f92adaaed0bcb3907d982506f78925e9052 by Erlend Egeberg Aasland in branch 'main': bpo-42972: Track sqlite3 statement objects (GH-26475) https://github.com/python/cpython/commit/fffa0f92adaaed0bcb3907d982506f78925e9052 --

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Pablo Galindo Salgado : Removed file: https://bugs.python.org/file50077/DTD-Matching-Gift-Dashboard - Google Sheets.html ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Soffie Swan added the comment: thanks and god blesse you all -- nosy: +soffieswan015 type: -> behavior Added file: https://bugs.python.org/file50077/DTD-Matching-Gift-Dashboard - Google Sheets.html ___ Python tracker

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +25070 pull_request: https://github.com/python/cpython/pull/26475 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Pablo Galindo Salgado added the comment: New changeset f097d2302be46b031687726011b86fc241a042ef by Miss Islington (bot) in branch '3.10': bpo-42972: Fully implement GC protocol for xxlimited (GH-26451) (GH-26460)

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset ff359d735f1a60878975d1c5751bfd2361e84067 by Miss Islington (bot) in branch '3.10': bpo-42972: Fix sqlite3 traverse/clear functions (GH-26452) (GH-26461) https://github.com/python/cpython/commit/ff359d735f1a60878975d1c5751bfd2361e84067

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset d1124b09e8251061dc040cbd396f35ae57783f4a by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fix sqlite3 traverse/clear functions (GH-26452) https://github.com/python/cpython/commit/d1124b09e8251061dc040cbd396f35ae57783f4a --

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +25056 pull_request: https://github.com/python/cpython/pull/26461 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset 4b20f2574d412f4c4a5b1ab799d8e71a5dd3b766 by Hai Shi in branch 'main': bpo-42972: Fully implement GC protocol for xxlimited (GH-26451) https://github.com/python/cpython/commit/4b20f2574d412f4c4a5b1ab799d8e71a5dd3b766 --

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +25055 pull_request: https://github.com/python/cpython/pull/26460 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +25046 pull_request: https://github.com/python/cpython/pull/26452 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by hai shi : -- pull_requests: +25045 pull_request: https://github.com/python/cpython/pull/26451 ___ Python tracker ___ ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Pablo Galindo Salgado added the comment: New changeset 0d399516320d8dfce4453037338659cef3a2adf4 by Ken Jin in branch '3.10': [3.10] bpo-42972: Fully support GC for _winapi.Overlapped (GH-26381) (#26430) https://github.com/python/cpython/commit/0d399516320d8dfce4453037338659cef3a2adf4

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset 490b638e63558013b71dbfba6e47cb9e6d80c911 by Ken Jin in branch 'main': bpo-42972: Fix GC assertion error in _winapi by untracking Overlapped earlier (GH(26429) https://github.com/python/cpython/commit/490b638e63558013b71dbfba6e47cb9e6d80c911

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

miss-islington added the comment: New changeset 1c0106ca8c72d671ad4e2b553489d786d06fce03 by Miss Islington (bot) in branch '3.10': bpo-42972: Fully implement GC protocol for functools LRU cache (GH-26423) https://github.com/python/cpython/commit/1c0106ca8c72d671ad4e2b553489d786d06fce03

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +25025 pull_request: https://github.com/python/cpython/pull/26431 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: I'm not fully satified by the overlapped_dealloc() implementation neither. There is an unpleasant code path for Windows XP but it's no longer needed in Python 3.11. I would prefer to always call PyObject_GC_UnTrack() and call it earlier. See the dicsussion

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: I'm not fully satisfied by the implementation of the two LRU types in functools. See the discussion in these two PRs: https://github.com/python/cpython/pull/26363 https://github.com/python/cpython/pull/26423 The _lru_list_elem doesnt implement the GC

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Ken Jin : -- pull_requests: +25024 pull_request: https://github.com/python/cpython/pull/26430 ___ Python tracker ___ ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Ken Jin : -- pull_requests: +25023 pull_request: https://github.com/python/cpython/pull/26429 ___ Python tracker ___ ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +25022 pull_request: https://github.com/python/cpython/pull/26427 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset eb8ab04dd7fe6bb9a4eefb5e60d7b6ca887e0148 by Miss Islington (bot) in branch '3.10': bpo-42972: Fully implement GC protocol for functools keywrapper and partial types (GH-26363) (GH-26424)

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +25021 pull_request: https://github.com/python/cpython/pull/26426 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset 0fa282c55f1a45765340cb24ed65c90ffe2aa405 by Ken Jin in branch 'main': bpo-42972: Fully support GC for _winapi.Overlapped (GH-26381) https://github.com/python/cpython/commit/0fa282c55f1a45765340cb24ed65c90ffe2aa405 --

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +25020 pull_request: https://github.com/python/cpython/pull/26425 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset 3f8d33252722750e6c019d3df7ce0fabf7bdd45e by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully implement GC protocol for functools LRU cache (GH-26423) https://github.com/python/cpython/commit/3f8d33252722750e6c019d3df7ce0fabf7bdd45e

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +25019 pull_request: https://github.com/python/cpython/pull/26424 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset 8994e9c2cd775ddf7b0723824da53fe0d7c039ac by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully implement GC protocol for functools keywrapper and partial types (GH-26363)

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +25018 pull_request: https://github.com/python/cpython/pull/26423 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset da9e0cb4dedf818540ad1f06305bb1ca9e568f51 by Miss Islington (bot) in branch '3.10': bpo-42972: Fully implement GC protocol for re types (GH-26368) (GH-26414) https://github.com/python/cpython/commit/da9e0cb4dedf818540ad1f06305bb1ca9e568f51

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +25008 pull_request: https://github.com/python/cpython/pull/26414 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset d1c732912e20e89815aca2d986442d349e82e31f by Miss Islington (bot) in branch '3.10': bpo-42972: Fully support GC protocol for _operator heap types (GH-26371) (GH-26413)

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +25007 pull_request: https://github.com/python/cpython/pull/26413 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset f4b70c22c8e37dd7a06702e30b121a6651683421 by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully support GC protocol for _operator heap types (GH-26371) https://github.com/python/cpython/commit/f4b70c22c8e37dd7a06702e30b121a6651683421

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Erlend E. Aasland added the comment: I can't contribute to that discussion, as it is on the committers ml, but I'll keep an eye on it. I'll refrain from further development on this issue until there's a consensus amongst the core devs. -- ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Pablo Galindo Salgado added the comment: Please, check also the discusion happening here: https://mail.python.org/archives/list/python-committ...@python.org/thread/FHFI7QKWNHAVWVFTCHJGTYD3ZFVEUXDD/ -- ___ Python tracker

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset fba42d11880f444bb94d9891e3949f082a57b9a9 by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully implement GC protocol for re types (GH-26368) https://github.com/python/cpython/commit/fba42d11880f444bb94d9891e3949f082a57b9a9 --

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +25005 pull_request: https://github.com/python/cpython/pull/26411 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: > GH-26399 is failing with an access violation on Windows. It's failing in one > of the flaky tests. I wonder if the segfault is related to flaky tests > somehow... I created bpo-44252 to track this crash, it might be unrelated to commit

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: I'm not sure that it's safe to call PyObject_ClearWeakRefs() in tp_clear function. PyObject_ClearWeakRefs() comment starts with: "This function is called by the tp_dealloc handler to clear weak references." For example in Modules/arraymodule.c, I don't

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

miss-islington added the comment: New changeset da8097aaf5a55c23f5b5ddbeffc2d90d06e00d93 by Miss Islington (bot) in branch '3.10': bpo-42972: Fully support GC for mmap heap types (GH-26373) https://github.com/python/cpython/commit/da8097aaf5a55c23f5b5ddbeffc2d90d06e00d93 --

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset e73b3b1cd48c92d847990e220cb9cbdbde86476a by Miss Islington (bot) in branch '3.10': bpo-42972: Fully support GC protocol for _queue.SimpleQueue (GH-26372) (GH-26406)

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset ea47a8a71ad56ec349f02bf8c6a1d3bf04acabcc by Miss Islington (bot) in branch '3.10': bpo-42972: Fully implement GC protocol for ssl heap types (GH-26370) (GH-26399) https://github.com/python/cpython/commit/ea47a8a71ad56ec349f02bf8c6a1d3bf04acabcc

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset 318adeba780851c416505e48a3454cacca831419 by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully support GC for mmap heap types (GH-26373) https://github.com/python/cpython/commit/318adeba780851c416505e48a3454cacca831419 --

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +25000 pull_request: https://github.com/python/cpython/pull/26407 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: New changeset 4d7f8f9f7fb09ea8eb4e43409a16a91b0bf18571 by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully support GC protocol for _queue.SimpleQueue (GH-26372) https://github.com/python/cpython/commit/4d7f8f9f7fb09ea8eb4e43409a16a91b0bf18571

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +24999 pull_request: https://github.com/python/cpython/pull/26406 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

miss-islington added the comment: New changeset 0bf0500baa4cbdd6c5668461c2a2a008121772be by Miss Islington (bot) in branch '3.10': bpo-42972: Fully support GC for pyexpat, unicodedata, and dbm/gdbm heap types (GH-26376)

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

STINNER Victor added the comment: So it seems like the weakref list (__weaklistoffset__) doesn't have to be handled by visit, clear or free functions, it only has to be deallocated with PyObject_ClearWeakRefs() in the dealloc function. I noticed that when reviewing

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Erlend E. Aasland added the comment: Hm, I'm unable to reproduce it w/addr sanitiser on macOS (FWIW). $ ./python.exe -m test test_ssl -F -u all -m test_pha_required_nocert Passing 1000 successful runs now. I'll see if I can get a Win dev env set up later. --

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Christian Heimes added the comment: GH-26399 is failing with an access violation on Windows. It's failing in one of the flaky tests. I wonder if the segfault is related to flaky tests somehow...

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

miss-islington added the comment: New changeset 4431922f92747f77e3eb790c6d1881232e1b5e8c by Miss Islington (bot) in branch '3.10': [3.10] bpo-42972: Fully support GC for hashlib heap types (GH-26374) (GH-26398) https://github.com/python/cpython/commit/4431922f92747f77e3eb790c6d1881232e1b5e8c

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +24992 pull_request: https://github.com/python/cpython/pull/26399 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Christian Heimes added the comment: New changeset dcb8786a9848516e823e090bb36079678913d8d3 by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully implement GC protocol for ssl heap types (GH-26370) https://github.com/python/cpython/commit/dcb8786a9848516e823e090bb36079678913d8d3

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Christian Heimes added the comment: New changeset 6ef5ba391d700bde7ec3ffd5fb7132a30dd309c4 by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully support GC for hashlib heap types (GH-26374) https://github.com/python/cpython/commit/6ef5ba391d700bde7ec3ffd5fb7132a30dd309c4 --

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +24991 pull_request: https://github.com/python/cpython/pull/26398 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Nick Coghlan added the comment: New changeset 59af59c2dfa52dcd5605185263f266a49ced934c by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully support GC for pyexpat, unicodedata, and dbm/gdbm heap types (GH-26376)

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +24990 pull_request: https://github.com/python/cpython/pull/26397 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Ken Jin added the comment: > it creates nearly 100 objects Oops sorry I think I'm wrong. most of those objects may be borrowed refs. Just 1 type object is causing the leak. -- ___ Python tracker

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Ken Jin added the comment: _winapi is leaky still even with my PR: >>> import sys,gc >>> for _ in range(5): ... print(sys.gettotalrefcount()) ... import _winapi ... del sys.modules['_winapi'] ... del _winapi ... gc.collect() ... 50468 51076 51432 51788 52144 I just noticed this, but

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Ken Jin : -- nosy: +kj nosy_count: 8.0 -> 9.0 pull_requests: +24973 pull_request: https://github.com/python/cpython/pull/26381 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Erlend E. Aasland added the comment: I've opened PR's to fix most of the heap types converted during the 3.10 alpha phase. What's missing (of the 3.10 batch) is: - _thread types (this needs special care) - winapi__overlapped.Overlapped (I currently don't have a Win dev env at hand) For the

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +24968 pull_request: https://github.com/python/cpython/pull/26376 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

hai shi added the comment: > * functools._lru_list_elem Looks like this type have performance in issue PR-5008 when supporting GC. I am not sure there have other similar questions or not. -- ___ Python tracker

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Pablo Galindo Salgado added the comment: Victor, can you take a look at the opened PRs? -- ___ Python tracker ___ ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Neil Schemenauer : -- nosy: +nascheme ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +24966 pull_request: https://github.com/python/cpython/pull/26374 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Erlend E. Aasland added the comment: Thanks! Hashlib PR comin' up. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +24964 pull_request: https://github.com/python/cpython/pull/26373 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +24963 pull_request: https://github.com/python/cpython/pull/26372 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +24960 pull_request: https://github.com/python/cpython/pull/26371 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +24959 pull_request: https://github.com/python/cpython/pull/26370 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Christian Heimes added the comment: Please open PRs and assign them to me. I'll review them as soon as possible. -- ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Erlend E. Aasland added the comment: Christian, I've got a PR ready for Modules/_ssl.c, but I won't submit it if you'd rather do it yourself. I'll stay off the sha/md5 types unless you approve :) -- nosy: +christian.heimes ___ Python tracker

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +24957 pull_request: https://github.com/python/cpython/pull/26368 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +24954 pull_request: https://github.com/python/cpython/pull/26363 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

miss-islington added the comment: New changeset 534da740a2586357d204ab5f446295b9ce220787 by Miss Islington (bot) in branch '3.10': bpo-42972: Fully implement GC protocol for arraymodule types (GH-26114) https://github.com/python/cpython/commit/534da740a2586357d204ab5f446295b9ce220787

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Pablo Galindo Salgado added the comment: New changeset bd404ccac0d3e8358995ac0cbeec9373bb6c4d96 by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully implement GC protocol for arraymodule types (GH-26114)

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- pull_requests: +24953 pull_request: https://github.com/python/cpython/pull/26362 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

miss-islington added the comment: New changeset e8d9df0089e30a06d837fa2cfbd070e01531701f by Miss Islington (bot) in branch '3.10': bpo-42972: Fully implement GC protocol for sqlite3 heap types (GH-26104) https://github.com/python/cpython/commit/e8d9df0089e30a06d837fa2cfbd070e01531701f

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +24952 pull_request: https://github.com/python/cpython/pull/26361 ___ Python tracker

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Pablo Galindo Salgado added the comment: New changeset d3c277a59c3d93fb92f7026f63678083d1d49fc5 by Erlend Egeberg Aasland in branch 'main': bpo-42972: Fully implement GC protocol for sqlite3 heap types (GH-26104)

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Erlend E. Aasland added the comment: Is there a deterministic way to test these changes? Will something a la this be sufficient: import gc import sys gc.collect() before = sys.gettotalrefcount() import somemod del sys.modules['somemod'] del somemod gc.collect() after =

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: -23226 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +24759 pull_request: https://github.com/python/cpython/pull/26114 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Erlend E. Aasland added the comment: I've added a checkbox for types that fully implement the GC protocol to https://discuss.python.org/t/list-of-built-in-types-converted-to-heap-types/8403/1. Heap types that fully implement the GC protocol: * _abc._abc_data * _bz2.BZ2Compressor *

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend E. Aasland : -- pull_requests: +24746 pull_request: https://github.com/python/cpython/pull/26104 ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Pablo Galindo Salgado added the comment: I'm marking this as a 3.10 release blocker untill all converted types that are in 3.10 have GC support. -- nosy: +pablogsal priority: normal -> release blocker ___ Python tracker

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend Egeberg Aasland : -- keywords: +patch pull_requests: +23226 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23428 ___ Python tracker

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Erlend Egeberg Aasland added the comment: Should we proceed with fixing GC for all heap types before continuing work with bpo-40077? -- ___ Python tracker ___

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by hai shi : -- nosy: +shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42972] [C API] Heap types (PyType_FromSpec) must fully implement the GC protocol

Change by Erlend Egeberg Aasland : -- nosy: +erlendaasland ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

  1   2   >