[issue43178] Redundant method overrides in queue

2021-02-10 Thread Raymond Hettinger
Raymond Hettinger added the comment: I prefer to keep the code as-is. It is microscopically faster than than just inheriting the methods, but more importantly it makes it easier to read the code and know that it is correct. We're instructing people to override all four methods when

[issue43178] Redundant method overrides in queue

2021-02-09 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 1.0 -> 2.0 pull_requests: +23279 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24488 ___ Python tracker

[issue43178] Redundant method overrides in queue

2021-02-09 Thread Peleg Shilo
New submission from Peleg Shilo : PriorityQueue and LIFOQueue override the _qsize method without actually changing it. They should just inherit it normally. -- components: Library (Lib) messages: 386699 nosy: peleg2 priority: normal severity: normal status: open title: Redundant