[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

Erlend E. Aasland added the comment: It seems to me that this issue can be closed as fixed. Do you have further PR's for this, Petr? -- nosy: +erlendaasland status: open -> pending ___ Python tracker __

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

Petr Viktorin added the comment: New changeset 7bb1cafa4e3d648669212ea4c6d11d6eafc6da23 by Petr Viktorin in branch 'master': bpo-43239: Export PyCFunction_New with PyAPI_FUNC (GH-24551) https://github.com/python/cpython/commit/7bb1cafa4e3d648669212ea4c6d11d6eafc6da23 -- ___

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

hai shi added the comment: >> PyCFunction_NewEx is part of the limited API as well, even though it's >> undocumented. People can call it. > >Wait no, I wrote too soon. >PyCFunction_NewEx is part of the limited API as well, even though it's >>undocumented. People can call it. Find some 3rd us

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

Petr Viktorin added the comment: > By the way, I would suggest to move "#define PyCFunction_New(ML, SELF) > PyCFunction_NewEx((ML), (SELF), NULL)" to Include/cpython/methodobject.h Wait no, I wrote too soon. PyCFunction_NewEx is part of the limited API as well, even though it's undocumented

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

Petr Viktorin added the comment: > By the way, I would suggest to move "#define PyCFunction_New(ML, SELF) > PyCFunction_NewEx((ML), (SELF), NULL)" to Include/cpython/methodobject.h OK, I'll add that move to the PR. > Oh, it's not listed by Doc/data/stable_abi.dat and so not checked by > To

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

Change by Petr Viktorin : -- keywords: +patch pull_requests: +23334 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24551 ___ Python tracker ___ __

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

STINNER Victor added the comment: Oh, it's not listed by Doc/data/stable_abi.dat and so not checked by Tools/scripts/stable_abi.py. It's implemented explicitly as a function only for the stable ABI: PyObject * PyCFunction_New(PyMethodDef *ml, PyObject *self) { return PyCFunction_NewEx(ml

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

New submission from Petr Viktorin : PyCFunction_New is part of the Stable ABI (see bpo-21354), but it is not declared as PyAPI_FUNC, and thus not exported with GCC's -fvisibility=hidden. To match Windows, it should be declared. (I don't think this has any real impact, I just want to fix it bef