[issue43294] [sqlite3] unused variables in Connection begin, commit, and rollback

[Berker Peksag]

Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43294] [sqlite3] unused variables in Connection begin, commit, and rollback

[Berker Peksag]

Berker Peksag  added the comment:


New changeset 5e48e836883ac577acd69c7b9bdfe5c439cef47f by Erlend Egeberg 
Aasland in branch 'master':
bpo-43294: Remove unused variables in pysqlite_connection_*() (GH-24658)
https://github.com/python/cpython/commit/5e48e836883ac577acd69c7b9bdfe5c439cef47f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43294] [sqlite3] unused variables in Connection begin, commit, and rollback

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
keywords: +patch
pull_requests: +23443
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24658

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43294] [sqlite3] unused variables in Connection begin, commit, and rollback

[Erlend Egeberg Aasland]

New submission from Erlend Egeberg Aasland :

In Modules/_sqlite/connection.c:
pysqlite_connection_commit_impl(), pysqlite_connection_rollback_impl(), and 
_pysqlite_connection_begin() all call sqlite3_prepare_v2() with the fourth 
parameter (pzTail) set. This (output) parameter is never used, we can safely 
remove the tail variables, and just call sqlite3_prepare_v2() with NULL as the 
fourth parameter.


Also, there's a lot of code duplication here. A support function could help 
simplify this, but that's out of scope.

--
components: Library (Lib)
messages: 387510
nosy: berker.peksag, erlendaasland, serhiy.storchaka
priority: normal
severity: normal
status: open
title: [sqlite3] unused variables in Connection begin, commit, and rollback
type: enhancement
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com