[issue43406] Possible race condition between signal catching and signal.signal

STINNER Victor added the comment: New changeset 531f2ebd60a662111c78107935d249d3d52f9a4f by Miss Islington (bot) in branch '3.9': bpo-43406: Fix test_signal.test_stress_modifying_handlers() (GH-24815) (GH-24817)

[issue43406] Possible race condition between signal catching and signal.signal

miss-islington added the comment: New changeset ac5e23c540f5ec20fc390c72e097e0fdaf8b7ac9 by Miss Islington (bot) in branch '3.8': bpo-43406: Fix test_signal.test_stress_modifying_handlers() (GH-24815) https://github.com/python/cpython/commit/ac5e23c540f5ec20fc390c72e097e0fdaf8b7ac9

[issue43406] Possible race condition between signal catching and signal.signal

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43406] Possible race condition between signal catching and signal.signal

Change by miss-islington : -- pull_requests: +23582 pull_request: https://github.com/python/cpython/pull/24816 ___ Python tracker ___

[issue43406] Possible race condition between signal catching and signal.signal

Change by miss-islington : -- pull_requests: +23583 pull_request: https://github.com/python/cpython/pull/24817 ___ Python tracker ___

[issue43406] Possible race condition between signal catching and signal.signal

STINNER Victor added the comment: New changeset 1fa17e8cc62775a2e34b158135ce8589f9394f03 by Victor Stinner in branch 'master': bpo-43406: Fix test_signal.test_stress_modifying_handlers() (GH-24815) https://github.com/python/cpython/commit/1fa17e8cc62775a2e34b158135ce8589f9394f03 --

[issue43406] Possible race condition between signal catching and signal.signal

STINNER Victor added the comment: > The new functional test has two race conditions. I don't think that it's a bug in Python, but more race conditions in the test. -- ___ Python tracker

[issue43406] Possible race condition between signal catching and signal.signal

Change by STINNER Victor : -- pull_requests: +23581 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/24815 ___ Python tracker ___

[issue43406] Possible race condition between signal catching and signal.signal

STINNER Victor added the comment: The change added a new functional test. As I expected, it failed on "AMD64 Debian root". I expected it because the previously added functional test failed failed on "AMD64 Debian root", I reported the race condition in 2017 and it's still not fixed:

[issue43406] Possible race condition between signal catching and signal.signal

Change by Antoine Pitrou : -- pull_requests: +23546 pull_request: https://github.com/python/cpython/pull/24755 ___ Python tracker ___

[issue43406] Possible race condition between signal catching and signal.signal

Change by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43406] Possible race condition between signal catching and signal.signal

miss-islington added the comment: New changeset 1385f8355a036fd65aaf9c7e7ab48467ca922bcf by Miss Islington (bot) in branch '3.9': [3.9] bpo-43406: Fix possible race condition where ``PyErr_CheckSignals`` tries to execute a non-Python signal handler (GH-24756) (GH-24761)

[issue43406] Possible race condition between signal catching and signal.signal

miss-islington added the comment: New changeset 4715be8a4384159e47fb09e5f3bd077734842655 by Antoine Pitrou in branch '3.8': [3.8] bpo-43406: Fix possible race condition where ``PyErr_CheckSignals`` tries to execute a non-Python signal handler (GH-24756) (GH-24762)

[issue43406] Possible race condition between signal catching and signal.signal

Change by Antoine Pitrou : -- pull_requests: +23534 pull_request: https://github.com/python/cpython/pull/24762 ___ Python tracker ___

[issue43406] Possible race condition between signal catching and signal.signal

Antoine Pitrou added the comment: New changeset 68245b7a1030287294c65c298975ab9026543fd2 by Antoine Pitrou in branch 'master': bpo-43406: Fix possible race condition where ``PyErr_CheckSignals`` tries to execute a non-Python signal handler (GH-24756)

[issue43406] Possible race condition between signal catching and signal.signal

Change by miss-islington : -- nosy: +miss-islington nosy_count: 2.0 -> 3.0 pull_requests: +23533 pull_request: https://github.com/python/cpython/pull/24761 ___ Python tracker

[issue43406] Possible race condition between signal catching and signal.signal

Change by Antoine Pitrou : -- nosy: +neologix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43406] Possible race condition between signal catching and signal.signal

Change by Antoine Pitrou : -- keywords: +patch pull_requests: +23527 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/24756 ___ Python tracker

[issue43406] Possible race condition between signal catching and signal.signal

Antoine Pitrou added the comment: Here is a reproducer: https://gist.github.com/pitrou/e5a566e644730516b51de71145c5ea06 If you execute it, it will fail after a few iterations: sig 2 sig 2 sig 2 Traceback (most recent call last): File "/home/antoine/cpython/default/setinterrupt.py", line

[issue43406] Possible race condition between signal catching and signal.signal

New submission from Antoine Pitrou : We can receive signals (at the C level, in trip_signal() in signalmodule.c) while signal.signal is being called to modify the corresponding handler. Later when PyErr_CheckSignals() is called to handle the given signal, the handler may be a non-callable