[issue43785] Remove RLock from BZ2File

2021-04-13 Thread Inada Naoki
Inada Naoki added the comment: New changeset 695d47b51e3e197de5448a1eb2f618bef6d59ac8 by Inada Naoki in branch 'master': bpo-43785: Update bz2 document (GH-25351) https://github.com/python/cpython/commit/695d47b51e3e197de5448a1eb2f618bef6d59ac8 --

[issue43785] Remove RLock from BZ2File

2021-04-13 Thread Inada Naoki
Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue43785] Remove RLock from BZ2File

2021-04-11 Thread Inada Naoki
Change by Inada Naoki : -- pull_requests: +24086 pull_request: https://github.com/python/cpython/pull/25351 ___ Python tracker ___

[issue43785] Remove RLock from BZ2File

2021-04-11 Thread Inada Naoki
Inada Naoki added the comment: New changeset cc2ffcdfd78df3a18edae60df81b2f1b044b1634 by Inada Naoki in branch 'master': bpo-43785: Improve BZ2File performance by removing RLock (GH-25299) https://github.com/python/cpython/commit/cc2ffcdfd78df3a18edae60df81b2f1b044b1634 --

[issue43785] Remove RLock from BZ2File

2021-04-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: I see you're already tracking __iter__ in https://bugs.python.org/issue43787, perfect! :) -- ___ Python tracker ___

[issue43785] Remove RLock from BZ2File

2021-04-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: I'm not worried about compatibility on this for 3.10. Nobody realistically expects to be able to have multiple readers from a single BZ2File stream. They don't for the gzip or lzma equivalents. That isn't even a normal thing to do on an actual file.

[issue43785] Remove RLock from BZ2File

2021-04-09 Thread Ma Lin
Ma Lin added the comment: This change is backwards incompatible, it may break some code silently. If someone really needs better performance, they can write a BZ2File class without RLock by themselves, it should be easy. FYI, zlib module was added in 1997, bz2 module was added in 2002, lzma

[issue43785] Remove RLock from BZ2File

2021-04-09 Thread Inada Naoki
Inada Naoki added the comment: I will create a separated issue for __iter__, because it is same to gzip and lzma. -- title: bz2 performance issue. -> Remove RLock from BZ2File ___ Python tracker