[issue44011] Borrow asyncio ssl implementation from uvloop

Andrew Svetlov added the comment: New changeset 41ddcd3f40f8171a396e57b841a74fcc83884eab by Kumar Aditya in branch 'main': bpo-44011: Document ssl_shutdown_timeout added by revisited asyncio SSL implementation (GH-31597)

[issue44011] Borrow asyncio ssl implementation from uvloop

Change by Kumar Aditya : -- pull_requests: +29720 pull_request: https://github.com/python/cpython/pull/31597 ___ Python tracker ___

[issue44011] Borrow asyncio ssl implementation from uvloop

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue44011] Borrow asyncio ssl implementation from uvloop

Change by Andrew Svetlov : -- priority: critical -> normal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44011] Borrow asyncio ssl implementation from uvloop

Andrew Svetlov added the comment: The code had landed. Need a follow-up PR with documentation update (mention new ssl_shutdown_timeout arguments) -- ___ Python tracker ___

[issue44011] Borrow asyncio ssl implementation from uvloop

Andrew Svetlov added the comment: New changeset 13c10bfb777483c7b02877aab029345a056b809c by Kumar Aditya in branch 'main': bpo-44011: New asyncio ssl implementation (#31275) https://github.com/python/cpython/commit/13c10bfb777483c7b02877aab029345a056b809c --

[issue44011] Borrow asyncio ssl implementation from uvloop

Change by Kumar Aditya : -- versions: +Python 3.11 -Python 3.10 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue44011] Borrow asyncio ssl implementation from uvloop

Change by Christian Heimes : -- nosy: -christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44011] Borrow asyncio ssl implementation from uvloop

Kumar Aditya added the comment: I created a draft PR by rebasing the old implementation of 3.10 for 3.11 so we can investigate the build-bots failure and fix them so this can be committed for 3.11. See https://github.com/python/cpython/pull/31275 --

[issue44011] Borrow asyncio ssl implementation from uvloop

Change by Kumar Aditya : -- pull_requests: +29438 pull_request: https://github.com/python/cpython/pull/31275 ___ Python tracker ___

[issue44011] Borrow asyncio ssl implementation from uvloop

Kumar Aditya added the comment: Since it was reverted as it was beta period, Can this be committed again as 3.11 is in alpha currently? @asvetlov -- nosy: +kumaraditya303 ___ Python tracker

[issue44011] Borrow asyncio ssl implementation from uvloop

Pablo Galindo Salgado added the comment: Unfortunately I have reverted 5fb06edbbb769561e245d0fe13002bab50e2ae60 commit to unblock the beta release :( I know that nobody wants this but my responsibilities as a release manager is to safeguard the stability of the release and we are too close

[issue44011] Borrow asyncio ssl implementation from uvloop

Pablo Galindo Salgado added the comment: New changeset 7719953b30430b351ba0f153c2b51b16cc68ee36 by Pablo Galindo in branch 'master': bpo-44011: Revert "New asyncio ssl implementation (GH-17975)" (GH-25848) https://github.com/python/cpython/commit/7719953b30430b351ba0f153c2b51b16cc68ee36

[issue44011] Borrow asyncio ssl implementation from uvloop

Pablo Galindo Salgado added the comment: Specifically this part of both messages: >> If your change involves some platform-specific behaviour or has a >> non-trivial amount of C code, make sure you run the buildbots >> in your Pull Request by using the "test-with-buildbots" label ( >>

[issue44011] Borrow asyncio ssl implementation from uvloop

Pablo Galindo Salgado added the comment: I have created https://github.com/python/cpython/pull/25848 for the revert, in case this is not fixed in the next hours or so. Given the nature of PR 17975, this should have tested with the buildbots as the release team asked in:

[issue44011] Borrow asyncio ssl implementation from uvloop

Change by Pablo Galindo Salgado : -- pull_requests: +24531 pull_request: https://github.com/python/cpython/pull/25848 ___ Python tracker ___

[issue44011] Borrow asyncio ssl implementation from uvloop

Christian Heimes added the comment: When was https://buildbot.python.org/all/#/builders/464/builds/138 start? The build properties tab doesn't have a start timestamp. Andrew, increase timeout doesn't seem to help. It's looks like the test suite is leaking threads on error. --

[issue44011] Borrow asyncio ssl implementation from uvloop

Pablo Galindo Salgado added the comment: Since commit https://github.com/python/cpython/commit/5fb06edbbb769561e245d0fe13002bab50e2ae60 was merged there are multiple timeouts in several buildbots. Unfortunately if this is not fixed by the time I need to do the beta release I may need to

[issue44011] Borrow asyncio ssl implementation from uvloop

Change by Andrew Svetlov : -- pull_requests: +24529 pull_request: https://github.com/python/cpython/pull/25846 ___ Python tracker ___

[issue44011] Borrow asyncio ssl implementation from uvloop

Change by Andrew Svetlov : -- pull_requests: +24526 pull_request: https://github.com/python/cpython/pull/25842 ___ Python tracker ___

[issue44011] Borrow asyncio ssl implementation from uvloop

Christian Heimes added the comment: I have merged my PR to unblock buildbots. Karthikeyan has made suggestions how to improve the tests even further. CI also had some issues with OpenSSL 3.0.0-alpha15. Please run the tests with new OpenSSL version, too. "make multissltest" automates

[issue44011] Borrow asyncio ssl implementation from uvloop

Christian Heimes added the comment: New changeset 37ebdf0a866457ce825d0ff6e498a10938895760 by Christian Heimes in branch 'master': bpo-44011: Fix asyncio tests without ssl module (GH-25840) https://github.com/python/cpython/commit/37ebdf0a866457ce825d0ff6e498a10938895760 --

[issue44011] Borrow asyncio ssl implementation from uvloop

Christian Heimes added the comment: PR GH-25840 fixes most issues. Gentoo with X buildbot https://buildbot.python.org/all/#builders/465/builds/23 has one failing test. == ERROR: test_create_server_ssl_over_ssl

[issue44011] Borrow asyncio ssl implementation from uvloop

Karthikeyan Singaravelan added the comment: The PR made sslproto a hard dependency that even import asyncio fails on non-ssl builds and thus anything that indirectly import asyncio also fails. It seems some of the test modules can be skipped. Some parts of the asyncio codebase already has

[issue44011] Borrow asyncio ssl implementation from uvloop

Change by Karthikeyan Singaravelan : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44011] Borrow asyncio ssl implementation from uvloop

Change by Christian Heimes : -- pull_requests: +24524 pull_request: https://github.com/python/cpython/pull/25840 ___ Python tracker ___

[issue44011] Borrow asyncio ssl implementation from uvloop

Christian Heimes added the comment: The commit has broken multiple build bots, e.g .https://buildbot.python.org/all/#/builders/345/builds/134/steps/5/logs/stdio The new code is missing checks for presence of ssl module. It's an optional component. -- nosy: +christian.heimes

[issue44011] Borrow asyncio ssl implementation from uvloop

Andrew Svetlov added the comment: New changeset 5fb06edbbb769561e245d0fe13002bab50e2ae60 by Andrew Svetlov in branch 'master': bpo-44011: New asyncio ssl implementation (#17975) https://github.com/python/cpython/commit/5fb06edbbb769561e245d0fe13002bab50e2ae60 --

[issue44011] Borrow asyncio ssl implementation from uvloop

Change by Andrew Svetlov : -- keywords: +patch pull_requests: +24507 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17975 ___ Python tracker ___

[issue44011] Borrow asyncio ssl implementation from uvloop

New submission from Andrew Svetlov : There is a PR created a long time ago. Finally, I've ported tests for it also. The documentation doesn't mention new ssh_shutdown_timeout parameter yet. The latest changes from https://github.com/MagicStack/uvloop/pull/385 can be applied separately.