[issue44045] canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"

[Joannah Nanjekye]

Joannah Nanjekye  added the comment:


New changeset 2138b2edaf5acb3b9c162a9ba620923e286239a8 by Jürgen Gmach in 
branch 'main':
bpo-44045: fix spelling of uppercase vs upper-case (GH-25985)
https://github.com/python/cpython/commit/2138b2edaf5acb3b9c162a9ba620923e286239a8


--
nosy: +nanjekyejoannah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44045] canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"

[Andrei Kulakov]

Andrei Kulakov  added the comment:

On Sat, May 8, 2021 at 10:38 PM Eric V. Smith 
wrote:

>
> Eric V. Smith  added the comment:
>
> The stdlib seems to have settled on lowercase for the noun version,
> though. My two cents: no sense not being consist just because lower-case
> might also work.
>

 Sounds good to me, I'm not opposed to consistency!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44045] canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"

[Eric V. Smith]

Eric V. Smith  added the comment:

The stdlib seems to have settled on lowercase for the noun version, though. My 
two cents: no sense not being consist just because lower-case might also work.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44045] canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"

[Andrei Kulakov]

Andrei Kulakov  added the comment:

https://dictionary.cambridge.org/us/dictionary/english/lower-case lists 
lower-case as a valid variant for nouns as well as adjectives.

--
nosy: +andrei.avk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44045] canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"

[Jürgen Gmach]

Jürgen Gmach  added the comment:

Thank you for the feedback. I created a PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44045] canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"

[Jürgen Gmach]

Change by Jürgen Gmach :


--
keywords: +patch
pull_requests: +24637
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/25985

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44045] canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"

[Eric V. Smith]

Eric V. Smith  added the comment:

That's exactly the kind of manual check I had in mind. After all "anal 
retentive doesn't have a hyphen unless it's used as a compound adjective".

I think we should go with "lowercase" when a noun, and "lower-case" as an 
adjective.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44045] canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"

[Jürgen Gmach]

Jürgen Gmach  added the comment:

I did some more research.

It looks like US English tends to use `lowercase`, while British English tends 
to `lower case`, and as an alternative to `lowercase` you can also use 
`lower-case` when using it as an adjective.

See also https://en.wiktionary.org/wiki/lowercase

So, to wrap up:

- you could use lowercase and uppercase as a noun, as an adjective and as a verb
- you can use lower case and upper case only as a noun
- you can use lower-case and upper-case only as an adjective

If that is true - I am no native English speaker, and Éric does not like to 
convert them all to single words, it gets a bit tougher.

Some - to me - obvious wrong usages would be:

"All IMAP4rev1 commands are supported by methods of the same name (in 
lower-case)."
=> in lower case or in lowercase

"All POP3 commands are represented by methods of the same name, in lower-case; 
most return the response text sent by the server."
=> in lower case or in lowercase

"Wrapper around a file that converts output to upper-case."
=> to upper case or to uppercase

"Return a new UUID, in the format that MSI typically requires (i.e. in curly 
braces, and with all hexdigits in upper-case)."
=> in upper case or in uppercase

"Hostnames are compared lower case."
=> lower-case or lowercase

Éric, are you ok with my suggested changes or do you want me to close the issue?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44045] canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"

[Éric Araujo]

Éric Araujo  added the comment:

I don’t think that there is a problem to be fixed.
Separated «lower case» could be unfriendly, but the hyphen is there in the 
adjective forms so it seems that changing these instances would add churn for 
no benefit.

--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44045] canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"

[Eric V. Smith]

Eric V. Smith  added the comment:

I think we'd want to look at the 33 uses with hyphens to make sure removing the 
hyphen is correct (as opposed to just blindly make a change). But I'm generally 
supportive.

--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44045] canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"

[Jürgen Gmach]

New submission from Jürgen Gmach :

Yesterday, I was bitten by ConfigParser' default behavior to lowercase keys on 
reading.

When I looked in the documentation and the source code, I found that lowercase 
was sometimes written as "lower-case", e.g. here 
https://docs.python.org/3/library/configparser.html#configparser.ConfigParser.optionxform

The webster dictionary only accepts "lowercase" as a valid English word:
https://www.merriam-webster.com/dictionary/lowercase

Before I wanted to create a pull request for this one, I also grepped the 
complete source code with the following result:

lower-case24
lowercase207
upper-case 9
uppercase201

I'd like to create a pull request which canonicalizes the writing to a 
consistent "lowercase" resp. "uppercase".

Is there any core dev out there willing to review / merge this kind of PR?

--
messages: 392978
nosy: jugmac00
priority: normal
severity: normal
status: open
title: canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com