[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

Erlend E. Aasland added the comment: Thanks Pablo for merging, and Berker for pushing me to investigate further. Highly appreciated! -- ___ Python tracker ___ ___

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

Pablo Galindo Salgado added the comment: New changeset 243b6c3b8fd3144450c477d99f01e31e7c3ebc0f by Erlend Egeberg Aasland in branch 'main': bpo-44079: Strip superfluous statement cache from sqlite3.Connection (GH-25998) https://github.com/python/cpython/commit/243b6c3b8fd3144450c477d99f01e31e

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

Erlend E. Aasland added the comment: Berker: > My understanding is that their usages is a bit different: > one is for performance reasons (and it can configurable by users) and the > other is to keep track of statements inside a connection. > > I'm not fully sure that the both use cases can be

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

Erlend E. Aasland added the comment: Also, note that if identical SQL statements are created in multiple cursors belonging to the same connection, they will currently _not_ be added to the connection weak ref list. See the if (self->statement->in_use) in the middle of _pysqlite_query_execute

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

Erlend E. Aasland added the comment: > I'm not fully sure that the both use cases can be combined. I'm fully sure they can :) Did I miss anything in msg393942? AFAICS, there is no need for the weak ref list anymore. -- ___ Python tracker

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

Erlend E. Aasland added the comment: Yes, that seems to be the intention. But, I don't think there is a need to maintain the second list: 1. Resetting statements was historically needed both for commit and rollback; pending statements would block such operations. That's no longer the case fo

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

Berker Peksag added the comment: https://github.com/ghaering/pysqlite/commit/33f99be6be5ad7d69767ff172441f1a860416e82 states the following: - Use a list of weak references of statements in the Connection class to keep track of all statements used with this connection. This is neces

[issue44079] [sqlite3] remove superfluous statement weak ref list from connection object

Change by Erlend E. Aasland : -- title: [sqlite3] optimisation: remove statement weak ref list from connection object -> [sqlite3] remove superfluous statement weak ref list from connection object ___ Python tracker