[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: The 12 latest build on https://buildbot.python.org/all/#/builders/464 are green (success). Can this issue be closed now? We can reopen it later if the issue strikes back. -- ___ Python tracker

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 9c89d62073fa0bcfe68e59add5b55fbcbf7672ab by Miss Islington (bot) in branch '3.10': bpo-44282: Fix occasional test_incremental_editing failures on buildbots (GH-26491) (GH-26499) https://github.com/python/cpython/commit/9c89d62073fa0bcfe68e59add

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +25095 pull_request: https://github.com/python/cpython/pull/26499 ___ Python tracker _

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset adef445dc34685648bd0ea1c125df2ef143912ed by Tal Einat in branch 'main': bpo-44282: Fix occasional test_incremental_editing failures on buildbots (GH-26491) https://github.com/python/cpython/commit/adef445dc34685648bd0ea1c125df2ef143912ed

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread Tal Einat
Tal Einat added the comment: See PR GH-26491. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +25087 pull_request: https://github.com/python/cpython/pull/26491 ___ Python tracker ___ ___

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread Tal Einat
Tal Einat added the comment: On my machine it running the test many times with parallelization no longer causes any failures with this change. Also, running other tests which us the @run_in_tk_mainloop decorator, with the same 1ms delay as before, doesn't cause any such failures. PR forthc

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread Tal Einat
Tal Einat added the comment: > Running 12 duplicate tests in parallel on Windows on a 6 core (12 CPU) > machine with [...] resulted in nearly all failing. Yes, running test_idle in parallel with itself usually causes some failures due to UI focus being stolen from one instance by another. T

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: The other thing I thought is parameterizing the decorator to pass in a delay only for this test, but that require another layer of wrapping, which I cannot do right now. So I think we should just add skiptest for now. In fact, we only need to run it when e

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: The confusion is my fault: PR-26404 is where I first saw this failure, for the previously added tests, not where the test was added. I unlinked the erroneous message. Running 12 duplicate tests in parallel on Windows on a 6 core (12 CPU) machine with f:\d

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread Terry J. Reedy
Change by Terry J. Reedy : -- Removed message: https://bugs.python.org/msg394871 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread Tal Einat
Tal Einat added the comment: On Ubuntu 20.04, I've managed to occasionally get this issue to reproduce locally by running the test many times in parallel, repeatedly: parallel -n8 -N0 './python -m test -ugui test_idle -m test_colorizer' ::: $(seq 20) This appears to be an issue with our new

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread Tal Einat
Tal Einat added the comment: I'm investigating this now. If nothing obvious comes up, I'll revert that PR. -- ___ Python tracker ___ __

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread Tal Einat
Tal Einat added the comment: The latest PR where changes were made to IDLE's colorizer and its tests, including specifically adding the problematic test, is GH-25851. -- ___ Python tracker _

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread Tal Einat
Tal Einat added the comment: Please note that the referenced PR is not the correct one. I'll add a link to the right one shortly. -- ___ Python tracker ___ __

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-02 Thread STINNER Victor
STINNER Victor added the comment: Buildbots are very unstable these days. I propose to revert the change to give more time to IDLE developers to investigate the issue, and to be able to identify other regressions on buildbots. https://pythondev.readthedocs.io/ci.html#revert-on-fail I created

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-01 Thread Terry J. Reedy
New submission from Terry J. Reedy : idlelib.idle_test.test_colordelagator.ColorDelegatorTest.test_incremental_editing has failed on at least on the following machines. Pip32 CI Pipelines Win32 Gen3x https://buildbot.python.org/all/#/builders/464 x86 Gentoo Installed with X 3.x GenPR ht

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-01 Thread Tal Einat
Change by Tal Einat : -- keywords: +patch pull_requests: +25076 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/26404 ___ Python tracker ___

[issue44282] IDLE: ColorDelegatorTest test_incremental_editing failures

2021-06-01 Thread Terry J. Reedy
Terry J. Reedy added the comment: Followup to PR-26404, which added the tests. -- ___ Python tracker ___ ___ Python-bugs-list maili