[issue44942] Add number pad enter bind to TK's simpleDialog

2021-08-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue44942] Add number pad enter bind to TK's simpleDialog

2021-08-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Tk does not bind KP_Enter in standard TK dialogs. I do not think we should introduce additional discrepancy between dialogs implemented in Tk and Python. Please file a feature request for Tk. If they add a binding for KP_Enter we will follow them.

[issue44942] Add number pad enter bind to TK's simpleDialog

2021-08-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: This proposal is not a bug fix. In my testing on Windows today, Ryan is correct in saying (on the PR) that kp return key normally acts is same as normal return key. True regardless of Numlock. This is *also true*, at least on Windows, of instances of

[issue44942] Add number pad enter bind to TK's simpleDialog

2021-08-18 Thread Guido van Rossum
Guido van Rossum added the comment: Sorry, CLA is signed, but I'd like Terry Reedy to have a peek. -- nosy: +terry.reedy ___ Python tracker ___

[issue44942] Add number pad enter bind to TK's simpleDialog

2021-08-18 Thread Guido van Rossum
Guido van Rossum added the comment: It’s fine. We now need the PR author to sign the CLA. -- nosy: +gvanrossum ___ Python tracker ___

[issue44942] Add number pad enter bind to TK's simpleDialog

2021-08-18 Thread Electro707
Change by Electro707 : -- nosy: +Electro707 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44942] Add number pad enter bind to TK's simpleDialog

2021-08-17 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: I'm new to this system, if I'm understanding https://devguide.python.org/triaging/#nosy-list then it looks like the people listed for `tkinter` should be added to the Nosy List? -- nosy: +gpolo, serhiy.storchaka

[issue44942] Add number pad enter bind to TK's simpleDialog

2021-08-17 Thread Ryan Mast (nightlark)
New submission from Ryan Mast (nightlark) : Tk the number pad enter and main enter keys separately. The number pad enter button should be bound to `self.ok` in simpleDialog's `Dialog` class so that both enter buttons have the same behavior. A PR for this change has been submitted on GitHub