[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-26 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Neat! Thanks :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-26 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: > How is manually dispatched workflows different from just opening a PR to your > own fork? I do that from time to time in order to run the CI before opening a > PR against the CPython repo. Here are a few thoughts on how it is different: - They can

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-23 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > first-time contributors need a maintainer to approve the workflows for their > PRs How is manually dispatched workflows different from just opening a PR to your own fork? I do that from time to time in order to run the CI before opening a PR against

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-23 Thread Steve Dower
Steve Dower added the comment: > I think you could also test this out by going to my fork ... Good point, and I can't trigger a build on your fork. This seems okay to me. -- ___ Python tracker

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-23 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: > On the main request, provided the workflow_dispatch is only triggerable by > non-contributors in their own fork (without any of our tokens/etc.) then it's > fine by me. If it allows anyone to trigger CI builds against the main repo, > I'd rather

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-23 Thread Steve Dower
Steve Dower added the comment: > first-time contributors need a maintainer to approve the workflows for their > PRs This is an important security consideration, so I'd rather not go and change it. On the main request, provided the workflow_dispatch is only triggerable by non-contributors

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-23 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: Another observation, first-time contributors need a maintainer to approve the workflows for their PRs -- from the looks of it that isn't an instant process and could take a few days, so this also gives first-time contributors a way to check their

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-23 Thread Brett Cannon
Brett Cannon added the comment: Add Lukasz to get his opinion on this idea. -- nosy: +lukasz.langa ___ Python tracker ___ ___

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-21 Thread Ryan Mast (nightlark)
Change by Ryan Mast (nightlark) : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-21 Thread Ryan Mast (nightlark)
Change by Ryan Mast (nightlark) : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-21 Thread Ryan Mast (nightlark)
Change by Ryan Mast (nightlark) : -- keywords: +patch pull_requests: +26328 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27873 ___ Python tracker

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-21 Thread Ryan Mast (nightlark)
Change by Ryan Mast (nightlark) : -- nosy: +FFY00 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-21 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: * The main constraint is that the the `workflow_dispatch` trigger must be in the GHA workflow yaml files for the branch to be selectable as a target on the Actions tab when manually triggering a workflow. Having the change made to the main branch and

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-21 Thread Ryan Mast (nightlark)
New submission from Ryan Mast (nightlark) : Adding a workflow_dispatch trigger for the GitHub Actions jobs makes it possible to run the GHA CI jobs for commits to branches in a fork without opening a "draft/WIP" PR to one of the main release branches. It also runs the SSL tests which