[issue45034] Improve struct.pack out of range error messages

Mark Dickinson added the comment: The out-of-range error messages for unsigned short and short have been fixed, thanks to Nikita Sobolev. They resulted from a rather odd use of the Py_STRINGIFY macro, which meant that not only were the messages obscure, but they differed from system to

[issue45034] Improve struct.pack out of range error messages

Mark Dickinson added the comment: New changeset 8ca6b61e3fd7f1e2876126cee82da8d812c8462f by Nikita Sobolev in branch 'main': bpo-45034: Fix how upper limit is formatted for `struct.pack("H", ...)` (GH-28178) https://github.com/python/cpython/commit/8ca6b61e3fd7f1e2876126cee82da8d812c8462f

[issue45034] Improve struct.pack out of range error messages

Change by Nikita Sobolev : -- keywords: +patch pull_requests: +26605 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28178 ___ Python tracker ___

[issue45034] Improve struct.pack out of range error messages

Terry J. Reedy added the comment: Go ahead, with the understanding that there is no guaranteed acceptance of the change, even with a good patch. There may be reasons for the status quo that neither Steven nor I are aware of. I don't think that either of the listed experts, added as nosy,

[issue45034] Improve struct.pack out of range error messages

Nikita Sobolev added the comment: I would like to work on this if nobody else has already started :) -- nosy: +sobolevn ___ Python tracker ___

[issue45034] Improve struct.pack out of range error messages

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45034] Improve struct.pack out of range error messages

Terry J. Reedy added the comment: I agree, including use of hex, if possible, for unsigned (non-negative) values. Grepping 'format requires' returns F:\dev\3x\Modules\_struct.c: 365: "'%c' format requires 0 <= number <= %zu", F:\dev\3x\Modules\_struct.c: 371: "'%c'

[issue45034] Improve struct.pack out of range error messages

New submission from Steven D'Aprano : Packing errors using struct in 3.9 seem to be unnecessarily obfuscated to me. >>> import struct >>> struct.pack('H', 7) Traceback (most recent call last): File "", line 1, in struct.error: ushort format requires 0 <= number <=