[issue45249] Update doctect SyntaxErrors for location range

miss-islington added the comment: New changeset 5df35faf3611b459f7f32bfe9fd2ffa7fb2dc59e by Miss Islington (bot) in branch '3.10': bpo-45249: Fix caret location when end_offset is set to 0 (GH-28855) https://github.com/python/cpython/commit/5df35faf3611b459f7f32bfe9fd2ffa7fb2dc59e

[issue45249] Update doctect SyntaxErrors for location range

Change by Pablo Galindo Salgado : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue45249] Update doctect SyntaxErrors for location range

miss-islington added the comment: New changeset fe0d9e22a52a10c4cbe52254b51f2d4e74d83568 by Pablo Galindo Salgado in branch 'main': bpo-45249: Fix caret location when end_offset is set to 0 (GH-28855) https://github.com/python/cpython/commit/fe0d9e22a52a10c4cbe52254b51f2d4e74d83568

[issue45249] Update doctect SyntaxErrors for location range

Change by miss-islington : -- pull_requests: +27277 pull_request: https://github.com/python/cpython/pull/28994 ___ Python tracker ___

[issue45249] Update doctect SyntaxErrors for location range

Change by Pablo Galindo Salgado : -- pull_requests: +27162 pull_request: https://github.com/python/cpython/pull/28855 ___ Python tracker ___

[issue45249] Update doctect SyntaxErrors for location range

Change by Pablo Galindo Salgado : -- pull_requests: +27161 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/28854 ___ Python tracker ___

[issue45249] Update doctect SyntaxErrors for location range

Change by Pablo Galindo Salgado : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45249] Update doctect SyntaxErrors for location range

Change by daniel hahler : -- versions: +Python 3.10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45249] Update doctect SyntaxErrors for location range

daniel hahler added the comment: I've noticed a regression/change with the code change for this issue. When not catching the exception from `compile("invalid(", "", "single")` it has a caret below the opening parenthesis: ``` Traceback (most recent call last): File

[issue45249] Update doctect SyntaxErrors for location range

Pablo Galindo Salgado added the comment: New changeset 1e2058214fffcb3919e0e127145106ade40a0420 by Pablo Galindo (Miss Islington (bot)) in branch '3.10': bpo-45249: Ensure the traceback module prints correctly syntax errors with ranges (GH-28575)

[issue45249] Update doctect SyntaxErrors for location range

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45249] Update doctect SyntaxErrors for location range

miss-islington added the comment: New changeset c7fdd6879b5c8447ee65b1bec95a1db43837a7a5 by Miss Islington (bot) in branch '3.10': bpo-45249: Ensure the traceback module prints correctly syntax errors with ranges (GH-28575)

[issue45249] Update doctect SyntaxErrors for location range

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +26969 pull_request: https://github.com/python/cpython/pull/28587 ___ Python tracker

[issue45249] Update doctect SyntaxErrors for location range

Pablo Galindo Salgado added the comment: New changeset 20f439b6b9e1032930a31b88694ab9f37a09e6b4 by Pablo Galindo Salgado in branch 'main': bpo-45249: Ensure the traceback module prints correctly syntax errors with ranges (GH-28575)

[issue45249] Update doctect SyntaxErrors for location range

Change by Pablo Galindo Salgado : -- pull_requests: +26958 pull_request: https://github.com/python/cpython/pull/28575 ___ Python tracker ___

[issue45249] Update doctect SyntaxErrors for location range

Pablo Galindo Salgado added the comment: One important thing is that "traceback.print_exception" should correctly print syntax errors . -- ___ Python tracker ___

[issue45249] Update doctect SyntaxErrors for location range

Andrei Kulakov added the comment: Terry: please take a look - https://github.com/python/cpython/pull/28567/files . -- ___ Python tracker ___

[issue45249] Update doctect SyntaxErrors for location range

Change by Andrei Kulakov : -- keywords: +patch pull_requests: +26951 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/28567 ___ Python tracker

[issue45249] Update doctect SyntaxErrors for location range

Andrei Kulakov added the comment: Terry: I got it mostly working using your 2nd suggestion, I will do some testing and should be able to put up a PR in the next couple of days. Thanks for looking at this and explaining! -- ___ Python tracker

[issue45249] Update doctect SyntaxErrors for location range

Terry J. Reedy added the comment: In 3.10+, end_lineno and end_offset fields were added to SyntaxError objects and the args tuple. >>> try: compile('1 1', '', 'single') ... except SyntaxError as e: print(e.args) ... ('invalid syntax. Perhaps you forgot a comma?', ('', 1, 1, '1 1', 1, 4))