[issue45407] Support buffer protocol for _struct.Struct format argument

Change by Dong-hee Na : -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue45407] Support buffer protocol for _struct.Struct format argument

Dong-hee Na added the comment: New changeset 9f7a94fd66e05ae040a67e32c397091fe5939ced by Jeong YunWon in branch 'main': bpo-45407: Remove outdated XXX comment from Struct___init___impl (GH-28805) https://github.com/python/cpython/commit/9f7a94fd66e05ae040a67e32c397091fe5939ced --

[issue45407] Support buffer protocol for _struct.Struct format argument

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45407] Support buffer protocol for _struct.Struct format argument

Serhiy Storchaka added the comment: I prefer to remove the comment. The format string is a text by its nature, there is no reason to support arbitrary binary data. Bytes objects are only supported for compatibility (with Python 2 strings). -- nosy: +serhiy.storchaka

[issue45407] Support buffer protocol for _struct.Struct format argument

New submission from youknowone : This feature is commented as `XXX` for years. https://github.com/python/cpython/blob/4e605666b08b8f863cbbbdaa34bb06988e648d26/Modules/_struct.c#L1478 Giving a bug tracker id or removing the comment will clarify the problem. -- components: Library