[issue45413] Add install scheme for virtual environments

Filipe Laíns added the comment: With PR 31034 merged, we can now mark this as resolved. As mentioned in the PR, there are still some concerns about maintainability and avoiding similar issues to happen in the future. That can be done later, as people find time to work on it. Thanks!

[issue45413] Add install scheme for virtual environments

Petr Viktorin added the comment: New changeset 48d926269963cfe7a49c0a4f34af4fe9b832399b by Miro Hrončok in branch 'main': bpo-45413: Define "posix_venv", "nt_venv" and "venv" sysconfig installation schemes (GH-31034)

[issue45413] Add install scheme for virtual environments

Petr Viktorin added the comment: Steve, could you take a look at the PR discussion and chime in about how this should be done? -- ___ Python tracker ___

[issue45413] Add install scheme for virtual environments

Miro Hrončok added the comment: I've adapted the PR. See the latest commit (Instead of *venv* scheme, have *posix_venv* and *nt_venv*). -- ___ Python tracker ___

[issue45413] Add install scheme for virtual environments

Filipe Laíns added the comment: I don't think the proposal is incompatible with what I discussed. I haven't been super clear on my opinions on the implementation, so let me try to clarify them. - I think that we should use a static scheme, accessible on all platforms. - If this scheme needs

[issue45413] Add install scheme for virtual environments

Steve Dower added the comment: All I can say is that I wasn't aware of this discussion, or it blurred into the other discussions and didn't seem to need any attention from me. Once I was pinged on the pull request (and I'm *trying* to be better at checking GitHub notifications, though

[issue45413] Add install scheme for virtual environments

Petr Viktorin added the comment: > I think we want the scheme to be static and accessible on all platforms, like > the others. So it probably should be 'nt_venv' and 'posix_venv' with > additional/improved logic to help apps determine when they need each. Why? (This is a real question, I

[issue45413] Add install scheme for virtual environments

Filipe Laíns added the comment: I agree. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45413] Add install scheme for virtual environments

Steve Dower added the comment: I think we want the scheme to be static and accessible on all platforms, like the others. So it probably should be 'nt_venv' and 'posix_venv' with additional/improved logic to help apps determine when they need each. -- nosy: +steve.dower

[issue45413] Add install scheme for virtual environments

Miro Hrončok added the comment: The PR is now ready for review. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue45413] Add install scheme for virtual environments

Miro Hrončok added the comment: I've created a draft PR in https://github.com/python/cpython/pull/31034 It is still missing tests and I have not checked it on Windows, hence still a draft. -- ___ Python tracker

[issue45413] Add install scheme for virtual environments

Change by Miro Hrončok : -- keywords: +patch pull_requests: +29217 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31034 ___ Python tracker ___

[issue45413] Add install scheme for virtual environments

Miro Hrončok added the comment: I'll try to draft this change for Python 3.11. -- ___ Python tracker ___ ___ Python-bugs-list

[issue45413] Add install scheme for virtual environments

Change by Stefano Rivera : -- nosy: +stefanor ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45413] Add install scheme for virtual environments

Change by Lumír Balhar : -- nosy: +frenzy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45413] Add install scheme for virtual environments

Petr Viktorin added the comment: Starting out with just "venv" doesn't mean we can't add "posix_venv"/"nt_venv" later (if e.g. someone needs to install into a filesystem for another platform). -- nosy: +petr.viktorin ___ Python tracker

[issue45413] Add install scheme for virtual environments

Filipe Laíns added the comment: Yes, we could have several schemes, but I think having only one is more sensible. The implementation would be fairly easy. We would just copy the "nt" scheme if on Windows, otherwise "posix_prefix". -- ___ Python

[issue45413] Add install scheme for virtual environments

Miro Hrončok added the comment: The existing install schemes contain values for all different kinds of OSes, somehow named according to them. If we introduce a single "virtual"/"venv" scheme, it would need to have different contents on different OSes (e.g. Windows vs POSIX). I don't think

[issue45413] Add install scheme for virtual environments

Change by Filipe Laíns : -- title: Add install scheme for virtual environment -> Add install scheme for virtual environments ___ Python tracker ___