[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Terry J. Reedy]

Terry J. Reedy  added the comment:

For the open dialog, we only need the expanded extension list.  People with 
no-extension python code file must select 'all files'.  Once the file is open, 
we need the issource function to decide whether to turn on the colorizer.  I 
intend to review the patch itself tomorrow.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Terry J. Reedy]

Terry J. Reedy  added the comment:

A minimal version of util.py just for this issue is fine.  What is blocking the 
issue deciding exactly what the minimum should be.  Are both the extension list 
and function needed?

Alex says somewhere in PR comments that ispythonsource passes directories.  
That seems wrong.  Perhaps moving and revising it and making no-extension files 
browsable and removing the x.py(?) limitation should be a separate issue.  IDLE 
users on *nix don't mind using extensions.  I have not seen a complaint, though 
perhaps people who do mind silently use something else.  I need to check again 
how the editor function is used and decide if we can leave it alone for now.  
So don't remove anything just now.

I need to experiment with Ron's suggestion on my Mac.

The Windows context menu is definitely a separate issue.

Please add idle_test/example.pyi with the line in msg403741 for manual testing 
now and possibly future automatic testing.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Alex Waygood]

Alex Waygood  added the comment:

@terry, have you had a chance to glance at my PR at all? I'd really appreciate 
your review! :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Terry J. Reedy]

Terry J. Reedy  added the comment:

We can add the mac change once it is manually tested on some system.  I may try 
on my macbook.  Windows will be another PR or even issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Alex Waygood]

Alex Waygood  added the comment:

Shall I add the change to the mac file to my PR, or would it be better to leave 
it for a separate PR? (I'm not confident enough to make the changes to the 
Windows files.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Steve Dower]

Steve Dower  added the comment:

Bit more complicated. It'll need changes to 
Tools/msi/launcher/launcher_reg.wxs, Tools/msi/tcltk/tcltk_reg.wxs, and 
PC/layout/support/appxmanifest.py, but I don't think it's that obvious where 
(we don't want these files to open with py.exe by default, so they'll need a 
whole new definition).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Steve, how do we make it so that "Edit with IDLE" appears when right-clicking 
on a .pyi file in Windows explorer?  As easy as on mac (see Ronald's answer 
above)?

--
nosy: +steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Ronald Oussoren]

Ronald Oussoren  added the comment:

The most straightforward change for macOS is to add “pyi” to the list of 
extensions in “Mac/IDLE/IDLE.app/Contents/Info.plist”.  That way IDLE will be 
seen as a valid editor for .pyi files.

--
nosy: +ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Yes.  After this issue is done, we should open a new issue and nosy Steve 
Dower, who is in charge of that for Windows, and Ned Deily, in case anything 
should be done on mac.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[E. Paine]

E. Paine  added the comment:

Would it make sense, since this issue pretty much makes IDLE officially support 
.pyi files, to add the "Edit with IDLE" menu when right-clicking on a .pyi file 
in Windows explorer?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Alex Waygood]

Alex Waygood  added the comment:

Have posted my PR. I've tested it manually and run the IDLE test suite on it 
with the `-u all` setting; it seems fine. The new tests I've written are a bit 
thin on the ground right now, though. I may need some guidance/help if more 
extensive tests are needed -- I'm a little new to unittest.

One other thing I'm not sure on: the docstring at the top of `browser.py` 
includes the line "- finish removing limitation to x.py files 
(ModuleBrowserTreeItem)" in the TODO items. Can this be removed now?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Alex Waygood]

Change by Alex Waygood :


--
keywords: +patch
pull_requests: +27239
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/28950

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[E. Paine]

Change by E. Paine :


--
nosy: +epaine

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Alex Waygood]

Alex Waygood  added the comment:

Oh — I've already nearly finished a PR. Do you mind if I submit mine? Happy to 
make any changes you like, obviously.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I am going to call the file util.py and will work on a PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Thank you for doing the research.

I have been thinking about adding a file containing idlelib 'leaf' objects, 
those with no idlelib dependencies, which are needed in more than one file. 
would be to reduce the complexity of the idlelib dependency graph, which has 
enough cyclic dependencies to make startup tricky.  Time to do it.  
idlelib/common.py?, leaves.py?, or ???  Draft:
---
"""Idlelib objects with no external idlelib dependencies and which are needed 
in more than one idlelib module.  They are included here because a) they don't 
particularly belong elsewhere or b) because inclusion here simplifies the 
idlelib dependency graph.

TODO: Python versions (editor and help_about), tk version and patchlevel 
(pyshell, help_about, maxos?, editor?), std streams (pyshell, run), warning 
stuff (ditto).
"""

# python_extensions is used in editor, browser, and iomenu.
# .pyw is for Windows; .pyi is for stub files.
python_extensions = ('.py', '.pyw', '.pyi')  
extension_string = "*" + " *".join(python_extensions)
---

editor.EditorWindow.ispythonsource could be moved into the new file if a 
'firstline=None' argument were added.

OnDoubleClick should use IsExpandable.  IsExpandable should use the logic in 
ispythonsource so Linux no-extension python source can be browsed as well as 
edited.

After manual testing, add a new test_common.py file in idlelib.idle_test. After 
imports, it could start with one test:

class ExtensionTest(TestCase):
def test_stub(self):
self.assertIn('.pyi', common.python_extensions)
self.assertIn('.pyi', common.extension_string)

For IDLE, I can and will backport.

--
stage:  -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Alex Waygood]

Alex Waygood  added the comment:

It looks like support for .py files is hardcoded into IDLE's source code in the 
following places:


* browser.ModuleBrowserTreeItem.OnDoubleClick
* browser.ModuleBrowserTreeItem.IsExpandable
* browser.ModuleBrowserTreeItem.listchildren
* editor.ispythonsource  << This is the one that controls syntax highlighting
* iomenu.IOBinding.filetypes


If I were to file a PR adding support for .pyi files, would you prefer that I 
hardcoded ".pyi" in, or would it be better to add a SUPPORTED_FILES constant 
somewhere?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Terry J. Reedy]

Terry J. Reedy  added the comment:

It should be fairly easy to recognize x.pyi as a python file.  Just have to 
find the place.  Something like
  def f(i:int) -> int: ...
would have 'def' and 'int' highlighted.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

[Alex Waygood]

Change by Alex Waygood :


--
title: Support syntax highlighting for .pyi stub files -> IDLE: Support syntax 
highlighting for .pyi stub files

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com