[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Steve Dower added the comment: New changeset 4c616911b69ce07fb35da1721506bfaba0998c30 by Steve Dower in branch 'main': bpo-45506: Fix test_embed expecting to not find stdlib in source tree build when stdlib has been installed. (GH-29649)

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Change by Steve Dower : -- pull_requests: +27880 pull_request: https://github.com/python/cpython/pull/29649 ___ Python tracker ___

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Steve Dower added the comment: Hijacking this issue number for a related test failure I found: if you "make install" Python and then run the test_embed tests from the build directory, some will successfully find the stdlib under PREFIX and fail because they expect to never find it. PR

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Eric Snow added the comment: New changeset 7b438282d39e742b2628a32e7c6699a140ff4cfb by Eric Snow in branch 'main': bpo-45506: Stop skipping test_embed. (gh-29300) https://github.com/python/cpython/commit/7b438282d39e742b2628a32e7c6699a140ff4cfb --

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Change by Eric Snow : -- pull_requests: +27564 pull_request: https://github.com/python/cpython/pull/29300 ___ Python tracker ___

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Eric Snow added the comment: Thanks for bringing this up, Greg! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Gregory P. Smith added the comment: i'm considering this fixed based on my testing. we still lack buildbots using out of tree setup. i'll ponder that. But this issue need not track that infrastructure. -- assignee: -> eric.snow resolution: -> fixed stage: patch review ->

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Eric Snow added the comment: New changeset 17c61045c51512add61a9e75e9c7343cf4e4fb82 by Eric Snow in branch 'main': bpo-45506: Normalize _PyPathConfig.stdlib_dir when calculated. (#29040) https://github.com/python/cpython/commit/17c61045c51512add61a9e75e9c7343cf4e4fb82 --

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Eric Snow added the comment: New changeset f4b12440cf24d7636755aac5b2645e47713557c7 by Eric Snow in branch 'main': bpo-45506: Go back to not running most of test_embed in out-of-tree builds. (gh-29063) https://github.com/python/cpython/commit/f4b12440cf24d7636755aac5b2645e47713557c7

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Change by Eric Snow : -- pull_requests: +27330 pull_request: https://github.com/python/cpython/pull/29063 ___ Python tracker ___

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Barry A. Warsaw added the comment: FWIW, Greg's test case does not fail for me with 6a533a4238 -- nosy: +barry ___ Python tracker ___

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Eric Snow added the comment: The PR I put up should fix the problem. If it doesn't then I'll probably drop the checks in the second half of FrozenImporter._fix_module(). -- ___ Python tracker

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Change by Eric Snow : -- keywords: +patch pull_requests: +27311 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/29040 ___ Python tracker

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Ned Deily added the comment: @gps, on macOS, you may need to bump the open file descriptors limit for the test process, i.e. ulimit -n 1000. I build and run out-of-tree builds all the time on macOS. -- nosy: +ned.deily ___ Python tracker

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Eric Snow added the comment: > Do our buildbots only do in-tree builds? >From what I understand, we do not have any (stable?) buildbots that check >out-of-tree builds. FWIW, in the last month I started testing my changes out-of-tree before merging, after Victor once pointed out that I had

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Eric Snow added the comment: I'm looking into it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Gregory P. Smith added the comment: git bisect on Linux yielded this culprit change: ``` 79cf20e48d0b5d69d9fac2a0204b5ac2c366066a is the first bad commit commit 79cf20e48d0b5d69d9fac2a0204b5ac2c366066a Author: Eric Snow Date: Thu Oct 14 15:32:18 2021 -0600 bpo-21736: Set __file__ on

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Change by Gregory P. Smith : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Gregory P. Smith added the comment: further down in the tracebacks in that situation: ``` File "/Users/greg/oss/python/upstream/Lib/importlib/_bootstrap.py", line 887, in _fix_up_module assert module.__file__ == __file__, (module.__file__, __file__)

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

Gregory P. Smith added the comment: for easy pasting: git clone https://github.com/python/cpython.git upstream && \ mkdir b-u && cd b-u && \ ../upstream/configure --with-pydebug && make -j3 && \ ./python -m test.regrtest test_importlib [change python to python.exe for macos, adjust -j as

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

New submission from Gregory P. Smith : The behavior is odd, I don't really know how to characterize it other than something serious has gone wrong. Memory corruption thus differing failures perhaps? it seems like maybe a race condition? on the main branch (i cannot reproduce this on 3.10