Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Yes, vs2008 requires that variables must be declared at the start of a block,
and IIRC there is a AIX compiler that does not allow // comments.
--
nosy: +amaury.forgeotdarc
___
Python
STINNER Victor victor.stin...@haypocalc.com added the comment:
Is it still useful to ensure that ISO C89 compilers are supported in 2011?
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4558
Roumen Petrov bugtr...@roumenpetrov.info added the comment:
Issue with inline was resolved by configure macro.
--
Added file: http://bugs.python.org/file22035/python3-20110520-c89.patch
___
Python tracker rep...@bugs.python.org
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: +Python 3.2 -Python 2.6, Python 2.7, Python 3.0, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4558
___
Roumen Petrov [EMAIL PROTECTED] added the comment:
Socket module need to be patched too otherwise test_socket fail on UNIX
domain socket tests.
After clean build and with new patch the regression tests results are:
337 tests OK.
3 tests failed:
test_curses test_urllib2_localnet
Changes by Roumen Petrov [EMAIL PROTECTED]:
Removed file: http://bugs.python.org/file12253/python-trunk-20081206-c89.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4558
___
Roumen Petrov [EMAIL PROTECTED] added the comment:
:-( the last my comment is incomplete : work for me after minimal patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4558
___
Georg Brandl [EMAIL PROTECTED] added the comment:
Patch looks good.
--
nosy: +georg.brandl
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4558
___
___
Christian Heimes [EMAIL PROTECTED] added the comment:
The updated patch moves the compiler option to the right place.
Added file: http://bugs.python.org/file12247/with_stdc89_2.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4558
Roumen Petrov [EMAIL PROTECTED] added the comment:
There is no reason to overload configure script.
Please look into pyport.h :
#define Py_LOCAL(type) static type
#define Py_LOCAL_INLINE(type) static inline type
Someone add USE_INLINE - not finished.
I guess that other source files has to use
Roumen Petrov [EMAIL PROTECTED] added the comment:
P.S. About C++ comments ( // ) I think that another issue is already
opened (problem on AIX ? ) .
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4558
___
Christian Heimes [EMAIL PROTECTED] added the comment:
Python core code must be compliant with the C89 standard but we don't
have any checks for C89 compatibility. This patch adds a clean way to
check our code base.
You can verify my patch by adding a // comment somewhere in the code and
Roumen Petrov [EMAIL PROTECTED] added the comment:
make EXTRA_CFLAGS='-std=c89' works for me.
Added file: http://bugs.python.org/file12253/python-trunk-20081206-c89.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4558
New submission from Christian Heimes [EMAIL PROTECTED]:
The patch adds a configure option --with-stdc89. It also fixes some edge
cases in socketmodule.h and linuxaudiodev so all related modules can be
build in c89 mode.
I'm planning to add the configure option to the build bots in order to
14 matches
Mail list logo
