[issue45634] [sqlite3] don't combine error checks when adding integer constants

Erlend E. Aasland added the comment: Thanks for reviewing, Dong-hee! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45634] [sqlite3] don't combine error checks when adding integer constants

Dong-hee Na added the comment: New changeset ed91f959b032951620f32bcd93ff27223699a86a by Erlend Egeberg Aasland in branch '3.10': [3.10] bpo-45634: Don't combine error checks when adding `sqlite3` int constants (GH-29251). (GH-29343)

[issue45634] [sqlite3] don't combine error checks when adding integer constants

Change by Erlend E. Aasland : -- pull_requests: +27609 pull_request: https://github.com/python/cpython/pull/29343 ___ Python tracker ___

[issue45634] [sqlite3] don't combine error checks when adding integer constants

Dong-hee Na added the comment: New changeset 39b4d5938ce781af41f8c9da72dee46095a78642 by Erlend Egeberg Aasland in branch 'main': bpo-45634: Don't combine error checks when adding `sqlite3` int constants (GH-29251)

[issue45634] [sqlite3] don't combine error checks when adding integer constants

Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +27515 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29251 ___ Python tracker

[issue45634] [sqlite3] don't combine error checks when adding integer constants

New submission from Erlend E. Aasland : In Modules/_sqlite/module.c, add_integer_constants() accumulates the return values of repeated PyModule_AddIntMacro() calls. We should change this to instead bailing immediately on error. -- components: Extension Modules messages: 405124 nosy: