[issue45800] Move expat handling into configure and Makefile

[Christian Heimes]

Christian Heimes  added the comment:


New changeset 464e6616be86129e33af6d9e43540c260d6804d5 by Christian Heimes in 
branch 'main':
bpo-45800: Move pyexpat build setup into configure (GH-29547)
https://github.com/python/cpython/commit/464e6616be86129e33af6d9e43540c260d6804d5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45800] Move expat handling into configure and Makefile

[Christian Heimes]

Change by Christian Heimes :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45800] Move expat handling into configure and Makefile

[Christian Heimes]

Change by Christian Heimes :


--
keywords: +patch
pull_requests: +27796
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/29547

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45800] Move expat handling into configure and Makefile

[Christian Heimes]

Christian Heimes  added the comment:

An intermediate libexpat.a simplifies Modules/Setup.

The explicit rules are required to support BSD make. bmake does neither have 
"%.o: %.c" nor target variable overrides like GNU make.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45800] Move expat handling into configure and Makefile

[Christian Heimes]

New submission from Christian Heimes :

Move logic for --with-system-expat out of setup.py into configure and Makefile. 
This will enable --with-system-expat in Modules/Setup without manual patching.

* Set CFLAGS and LDFLAGS for pyexpat and libexpat in configure.
* Build a static libexpat.a from our copy of expat when --with-system-expat is 
not given
* Either link pyexpat with libexpat.a or system libexpat.

Basically use the same approach as decimal changeset bpo-45798.

--
assignee: christian.heimes
components: Build
messages: 406281
nosy: christian.heimes
priority: normal
severity: normal
status: open
title: Move expat handling into configure and Makefile
type: enhancement
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com